From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1373 invoked from network); 22 Jun 2005 13:59:44 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 22 Jun 2005 13:59:44 -0000 Received: (qmail 98564 invoked from network); 22 Jun 2005 13:59:39 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 22 Jun 2005 13:59:39 -0000 Received: (qmail 198 invoked by alias); 22 Jun 2005 13:59:36 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21372 Received: (qmail 189 invoked from network); 22 Jun 2005 13:59:36 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 22 Jun 2005 13:59:36 -0000 Received: (qmail 98304 invoked from network); 22 Jun 2005 13:59:36 -0000 Received: from cluster-e.mailcontrol.com (HELO rly11e.srv.mailcontrol.com) (217.79.216.190) by a.mx.sunsite.dk with SMTP; 22 Jun 2005 13:59:25 -0000 Received: from iris.logica.co.uk (iris.logica.co.uk [158.234.9.163]) by rly11e.srv.mailcontrol.com (MailControl) with ESMTP id j5MDxLgD015768 for ; Wed, 22 Jun 2005 14:59:21 +0100 Received: from trentino.logica.co.uk ([158.234.142.59]) by iris.logica.co.uk (8.12.3/8.12.3/Debian -4) with ESMTP id j5MDxKKM002750 for ; Wed, 22 Jun 2005 14:59:21 +0100 Received: from trentino.groupinfra.com (localhost [127.0.0.1]) by trentino.logica.co.uk (Postfix) with ESMTP id 946DD6BD87 for ; Wed, 22 Jun 2005 15:59:20 +0200 (CEST) X-VirusChecked: Checked X-StarScan-Version: 5.0.7; banners=.,-,- In-reply-to: <20050622131158.GB4591@localhost.localdomain> From: Oliver Kiddle References: <20050622131158.GB4591@localhost.localdomain> To: zsh-workers@sunsite.dk Subject: Re: PATCH: new shells completion type Date: Wed, 22 Jun 2005 15:59:20 +0200 Message-ID: <9002.1119448760@trentino.groupinfra.com> X-Scanned-By: MailControl A-05-01-01 (www.mailcontrol.com) X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.5 required=6.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.5 Doug Kearns wrote: > Here is a new completion type for shells. It seems to me that if we're > going to complete shells from /etc/shells then it should be restricted > _only_ to shells listed there. This will change the behaviour of useradd > completion which always included /bin/false. With useradd/usermod, it's very useful to have /bin/false as a match. If the user account won't need to login then that's a common way to ensure it can't. > - '-s[shell to execute rather than $SHELL]:shell name: _command_names -e' \ > + '-s[shell to execute rather than $SHELL]:shell:_shells' \ I don't use screen but does that option only get used with actual shells? > + shells=( ${(M)commands:#*/((|[abckz]|tc|ba)sh|false)} ) That branch is still adding /bin/false. If screen's -s option is commonly used, you may want to expand this a bit. Oliver This e-mail and any attachment is for authorised use by the intended recipient(s) only. It may contain proprietary material, confidential information and/or be subject to legal privilege. It should not be copied, disclosed to, retained or used by, any other party. If you are not an intended recipient then please promptly delete this e-mail and any attachment and all copies and inform the sender. Thank you.