From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10748 invoked from network); 21 Mar 2005 17:09:23 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by ns1.primenet.com.au with SMTP; 21 Mar 2005 17:09:23 -0000 Received: (qmail 76683 invoked from network); 21 Mar 2005 17:09:17 -0000 Received: from sunsite.dk (130.225.247.90) by a.mx.sunsite.dk with SMTP; 21 Mar 2005 17:09:16 -0000 Received: (qmail 25117 invoked by alias); 21 Mar 2005 17:09:13 -0000 Mailing-List: contact zsh-workers-help@sunsite.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 21043 Received: (qmail 25103 invoked from network); 21 Mar 2005 17:09:13 -0000 Received: from news.dotsrc.org (HELO a.mx.sunsite.dk) (130.225.247.88) by sunsite.dk with SMTP; 21 Mar 2005 17:09:13 -0000 Received: (qmail 76411 invoked from network); 21 Mar 2005 17:09:13 -0000 Received: from mail36.messagelabs.com (193.109.254.211) by a.mx.sunsite.dk with SMTP; 21 Mar 2005 17:09:03 -0000 X-VirusChecked: Checked X-Env-Sender: okiddle@yahoo.co.uk X-Msg-Ref: server-3.tower-36.messagelabs.com!1111424942!15298623!1 X-StarScan-Version: 5.4.11; banners=-,-,- X-Originating-IP: [158.234.9.163] Received: (qmail 3388 invoked from network); 21 Mar 2005 17:09:02 -0000 Received: from iris.logica.co.uk (158.234.9.163) by server-3.tower-36.messagelabs.com with SMTP; 21 Mar 2005 17:09:02 -0000 Received: from trentino.logica.co.uk ([158.234.142.59]) by iris.logica.co.uk (8.12.3/8.12.3/Debian -4) with ESMTP id j2LH8x5X008938 for ; Mon, 21 Mar 2005 17:08:59 GMT Received: from trentino.groupinfra.com (localhost [127.0.0.1]) by trentino.logica.co.uk (Postfix) with ESMTP id B836D1EC08 for ; Mon, 21 Mar 2005 18:08:38 +0100 (CET) X-VirusChecked: Checked X-StarScan-Version: 5.0.7; banners=.,-,- In-reply-to: <200503121046.54826.arvidjaar@newmail.ru> From: Oliver Kiddle References: <24297.1110533836@trentino.groupinfra.com> <200503121046.54826.arvidjaar@newmail.ru> To: zsh-workers@sunsite.dk Subject: Re: [PATCH] _fuser Solaris and SVR4 support Date: Mon, 21 Mar 2005 18:08:38 +0100 Message-ID: <9029.1111424918@trentino.groupinfra.com> X-Spam-Checker-Version: SpamAssassin 3.0.2 on a.mx.sunsite.dk X-Spam-Level: X-Spam-Status: No, score=-2.6 required=6.0 tests=AWL,BAYES_00 autolearn=ham version=3.0.2 X-Spam-Hits: -2.6 On 12 Mar, Andrey wrote: > > I actually meant - signal names should be completed only if -k is present > (because they are meaningless without). But currently it is possible to > implement only using ->state and it seemed too much work for such small > function. Normally we implement that by just checking for $+words[(r)-k] Does the new patch below now do the right thing? > Will "prerequisite options" be generally useful? I.e. something like > > [-a]-b:.... They would. But changing _arguments isn't exactly easy. An alternative syntax might be something like (!-a), mixing them with the exclusion lists. Oliver Index: Completion/Unix/Command/_fuser =================================================================== RCS file: /cvsroot/zsh/zsh/Completion/Unix/Command/_fuser,v retrieving revision 1.2 diff -u -r1.2 _fuser --- Completion/Unix/Command/_fuser 10 Mar 2005 18:38:16 -0000 1.2 +++ Completion/Unix/Command/_fuser 21 Mar 2005 17:02:20 -0000 @@ -27,7 +27,7 @@ ) ;; sysv4 ) - arg1=( ':signal:_signals -p' ) + (( $+words[(r)-k] )) && arg1=( ':signal:_signals -p' ) ;; esac