zsh-workers
 help / color / mirror / code / Atom feed
From: "Jun T." <takimoto-j@kba.biglobe.ne.jp>
To: zsh-workers@sunsite.dk
Subject: combining char in vi-keybinding
Date: Sun, 20 Apr 2008 00:21:43 +0900	[thread overview]
Message-ID: <9038EB93-1E0B-4870-986A-CECD34805580@kba.biglobe.ne.jp> (raw)

Hre are two minor bugs related with the combining character support
in vi-keybinding.

(1) If the last character on the command line is a combining character,
and if I try to move the cursor to the end of line by vi commands
"l", "w", "$", etc., then cursor goes to the begining of the
previous line.

This may be fixed by repacing line 1054 of zle_main.c
		zlecs--;
by
		DECCS();


(2) If the cursor is on a combined character, vi command "x"
(vi-delete-char) deletes only the base character, leaving the
combining character (which is combined with the previous char).

It seems this can be fixed by replacing line 359 of zle_vi.c
	forekill(n, CUT_RAW);
by
	forekill(n, 0);
but I don't know what the side effect of this is.
Similar change may be needed in vibackwarddeletechar().

Jun


             reply	other threads:[~2008-04-19 15:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-19 15:21 Jun T. [this message]
2008-04-20 16:50 ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9038EB93-1E0B-4870-986A-CECD34805580@kba.biglobe.ne.jp \
    --to=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@sunsite.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).