From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18370 invoked from network); 18 Jul 2021 23:34:56 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 18 Jul 2021 23:34:56 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Subject:Cc:To:From:Date:References:In-Reply-To:Message-Id: Mime-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=9wPjv4w3Ge6J3F+UNN+GowgKmgqTZBlqbmfpiFWw4ME=; b=Fl8QLeQw+oSFpINmrpxU3MtgoB kVz/jxYYyRraf45FN6hcUqghKTt59THS/k14b2jVo3DxpWXp1R4+1lzqkENbCvTGFoPilFm3eE+/9 Y2WmlSusvk0c71HJk1jL2plka6FKhPK5jjCgkc2t8oj/5/slhuZIPe01qt7xmSZKljrx0gxHzPNbt Wr4okAMcTSSibWzArMZavbcRlgvIJecUW/8c38QQzXTvBYewjZp5FYPW2PYglecgi0OzK0yqtkP9Y GJaM4L7E1xA5mBb/MZdR+2iCgAFA83SLMrQt64KzeCchEYYr4iIO/H79yyJISehQ4lUob6qjqdXnM LkZbabrQ==; Received: from authenticated user by zero.zsh.org with local id 1m5GJD-000HPU-Cz; Sun, 18 Jul 2021 23:34:55 +0000 Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1m5GIw-000H6h-OF; Sun, 18 Jul 2021 23:34:39 +0000 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailauth.nyi.internal (Postfix) with ESMTP id E805A27C0054; Sun, 18 Jul 2021 19:34:36 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute3.internal (MEProxy); Sun, 18 Jul 2021 19:34:36 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrvdelgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtgfesthhqredtreerjeenucfhrhhomhepnfgrfihr vghntggvpgggvghljoiiqhhuvgiiuceolhgrrhhrhihvseiishhhrdhorhhgqeenucggtf frrghtthgvrhhnpedvgfeigffgudegleeuvdelfeejheefudfhtefhtdeggeevueekfedt jeetgeevkeenucffohhmrghinhepshhouhhrtggvfhhorhhgvgdrihhonecuvehluhhsth gvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgrrhhrhihvodhmvghs mhhtphgruhhthhhpvghrshhonhgrlhhithihqdduudehudekjeejtdegqdduudelvdejfe ekhedqlhgrrhhrhihvpeepiihshhdrohhrghesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id A011EA03996; Sun, 18 Jul 2021 19:34:36 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.5.0-alpha0-533-gf73e617b8a-fm-20210712.002-gf73e617b Mime-Version: 1.0 Message-Id: <906332f9-027b-4b21-bb7f-3fd7118154af@www.fastmail.com> In-Reply-To: References: <36227-1622676235.815398@zrY_.ZerV.zhJL> Date: Sun, 18 Jul 2021 19:34:02 -0400 From: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= To: zsh-workers@zsh.org Cc: "Marlon Richert" Subject: Re: [PATCH] Make _expand_alias more usable as a completer Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Seq: 49177 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Sun, Jun 20, 2021, at 6:24 PM, Marlon Richert wrote: > On Mon, Jun 21, 2021 at 12:08 AM Mikael Magnusson = wrote: > > > > On 6/20/21, Lawrence Vel=C3=A1zquez wrote: > > > On Thu, Jun 3, 2021, at 5:42 PM, Marlon Richert wrote: > > >> On Thu, Jun 3, 2021 at 2:24 AM Oliver Kiddle wrote:= > > >> > > >> > I also wonder if this would be better done from within _command= _names > > >> > directly but I'm not sure. > > >> > > >> Actually, I feel like it could instead be added to the _expand > > >> completer. Would that be a better idea than what I presented in t= his > > >> patch? > > > > > > Anyone have answers to Marlon's questions? > > > > If it helps, I disagree with conflating _expand_alias (expanding > > aliases) and _expand (filename expansion). >=20 > _expand already handles a lot more than just "filename expansion" > (which it actually does not handle at all). A quick test going through= > all forms of expansion listed at > https://zsh.sourceforge.io/Doc/Release/Expansion.html shows that > _expand currently handles all of the following: > * parameter expansion > * command substitution > * arithmetic expansion > * brace expansion > * filename generation > (but not history expansion, alias expansion, process substitution or > filename expansion). >=20 > Since alias expansion is in fact listed at > https://zsh.sourceforge.io/Doc/Release/Expansion.html, I don't think > it would be too weird to add it to the _expand completer. Any other feedback on 48946? --=20 vq