From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id 4F45A28C66 for ; Sat, 8 Jun 2024 09:39:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Subject:Cc:To:From:Date: References:In-Reply-To:Message-Id:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Ic2b7RatrBRJozQ1PmPY0D8jbG8HDxZU/LXFPopuN4I=; b=hNYCDfGZsXtkSRMrFgRsl6I0b0 9s/4EAY63mkGp6ySHCQsyyM6fJJXLpmCUqhKiVwhMKMI35qwnGUUY6HyKg/x5aZb46UbE1ZSmBQfk pOl50nKh//e2n8FLaec1m3jjdbRuk1lqcv467D7qWDSRZhCNNsfHfjionevWqHwuEjR/dQ1ufDygC rXFZV6I/Vzk9HaFqxN0lDeKQzp9yRj8XmMDDRj4ScOgvt5DY986QHxTaC9INZXXUV+I6W+BlPhdUR Y+7s9FQ+YqKZ7Ppl11MAxGXtezlEGcA0iZAQXOZSN0F/aZtwcOhLLzBTpZE3UgqtSYnhJUeX3VXbM 5fBBCswA==; Received: by zero.zsh.org with local id 1sFqfD-000K9z-Py; Sat, 08 Jun 2024 07:38:59 +0000 Received: by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1sFqec-000JoH-0I; Sat, 08 Jun 2024 07:38:22 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfauth.nyi.internal (Postfix) with ESMTP id F03251200043; Sat, 8 Jun 2024 03:38:19 -0400 (EDT) Received: from imap48 ([10.202.2.98]) by compute2.internal (MEProxy); Sat, 08 Jun 2024 03:38:19 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrfedtvddguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesthdtredtreerjeenucfhrhhomhepnfgr fihrvghntggvucggvghljoiiqhhuvgiiuceolhgrrhhrhihvseiishhhrdhorhhgqeenuc ggtffrrghtthgvrhhnpeelkeehjefgudefgeekueegudeghfevvdeljeehieeuffehveej gfehtefhudevhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehlrghrrhihvhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidquddu hedukeejjedtgedqudduledvjeefkeehqdhlrghrrhihvheppeiishhhrdhorhhgsehfrg hsthhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: iaa214773:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B6EC131A0065; Sat, 8 Jun 2024 03:38:19 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-497-g97f96844c-fm-20240526.001-g97f96844 MIME-Version: 1.0 Message-Id: <9070b9a6-268b-47a2-96ce-627e48aa6939@app.fastmail.com> In-Reply-To: <3bc6f058-4394-4b64-bd2e-44f7efbd5688@app.fastmail.com> References: <3bc6f058-4394-4b64-bd2e-44f7efbd5688@app.fastmail.com> Date: Sat, 08 Jun 2024 03:37:59 -0400 From: =?UTF-8?Q?Lawrence_Vel=C3=A1zquez?= To: "Martin Tournoij" Cc: zsh-workers@zsh.org Subject: Re: [PATCH] add cdtohome setting Content-Type: text/plain X-Seq: 52944 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Sat, Jun 8, 2024, at 1:51 AM, Martin Tournoij wrote: > A small patch to add a tcsh setting I miss. I don't have a strong initial opinion on whether this should be accepted or not, but... > -Change the current directory. In the first form, change the > -current directory to var(arg), or to the value of tt($HOME) if > -var(arg) is not specified. If var(arg) is `tt(-)', change to the > -previous directory. > +Change the current directory. In the first form, change the current > +directory to var(arg), or to the value of tt($HOME) if var(arg) is not > +specified unless the tt(CD_TO_HOME) option is not set, in which case > +var(arg) is required. If var(arg) is `tt(-)', change to the previous > +directory. I don't love how many negatives and chained clauses are jammed into this one sentence. I think something like this would be clearer: In the first form, change the current directory to var(arg) or to the value of tt($HOME) if var(arg) is omitted and the tt(CD_TO_HOME) option is set; if tt(CD_TO_HOME) is unset, var(arg) is required. > +pindex(CD_TO_HOME) > +pindex(NO_CD_TO_HOME) > +pindex(CDTOHOME) > +pindex(NOCDTOHOME) > +item(tt(CD_TO_HOME))( > +Don't go to home when using tt(cd) without any arguments. Isn't it the other way around? The option *enables* operand-less cd to go $HOME. (Not argument-less, because options are arguments.) Maybe: If set, a tt(cd) command without operands changes the current directory to the value of tt($HOME). If unset, tt(cd) requires at least one operand. -- vq