From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4302 invoked by alias); 25 Apr 2018 12:09:11 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42716 Received: (qmail 1323 invoked by uid 1010); 25 Apr 2018 12:09:11 -0000 X-Qmail-Scanner-Diagnostics: from mail-yw0-f181.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.161.181):SA:0(-1.9/5.0):. Processed in 1.359004 secs); 25 Apr 2018 12:09:11 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, T_DKIMWL_WL_MED,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: ricardo@giorni.co X-Qmail-Scanner-Mime-Attachments: |smime.p7s| X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=giorni-co.20150623.gappssmtp.com; s=20150623; h=from:mime-version:subject:date:references:to:in-reply-to:message-id; bh=A6/aftwS15Es/YSyzgPhagTaNbCM0AhmEs7aoZEdk14=; b=N/94Bance/HTuj3KDwOj6AdJiGvvzdITxO7E/6Q+26ScI/yN7j04ccJ5fve8nqGjMK uL50nPOtAGWRVExglx/Zx4s74GKNveGY1is0uUPoyY2KKZ75fBv15yYby5zI69RSrnX+ O962PIEuhzhfWVHQYZpMGkZ2mBoTCRLKCiTxkcBbSB1yGhKK3qBqNbUq86ymmumQMRtT vuj9/31IQpyyqz6mhc5UJ6kKQJhX9mXmdQhcVk7TCa4MsZi+h39mqcILy0hpyWowzh3N pYq4bCugduO6q3topgboeGop7F/dbEeeNbIossT5It9AF0YeMaccc7LdGxV4zqPjCOrW gI7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:date:references:to :in-reply-to:message-id; bh=A6/aftwS15Es/YSyzgPhagTaNbCM0AhmEs7aoZEdk14=; b=AwZuvZ3kFYuTopxPoi/cPuF/OY08fNKgARZunOJkq0iu185VfUHG8nnyzwFq5/GdAK E0fPdVK3sbOyWJdfTNT21iFlODgkaXGeeGGRtvEs5HFjzzERXOXDN8Ddp0aLXJM+eZXI 2pN7G2SddgVOJGNHHsXvm3vXHLm1146+zFBijByixc3rdo4awid69mGW+bBHMzsCDk0z J47N5B/R2Vvn2Ej5BCASGilBRSz0T1w6tdwtDmPKIzga2bsgU2737XkPPntmxAQLzGkS ECAOtxbpqEJa2kmYPAX7+aLTiWzJtFCIJq0Y1eJpdaROyN74wo2rsUdnHGa5kz2DYLPy qCxQ== X-Gm-Message-State: ALQs6tDkLPdmgpko1P/mOg7anJjAYwsKI8WLFGzCXOclLvBM3WtIAN5B RL6g+6zO621V56wdzrULxjduh93hw6c= X-Google-Smtp-Source: AIpwx4/5OUSVxfxn5iggcC6+7IsLOzeIM+0SJ8eOoo2BZ5KWlbrzwcOTg21GmLvRPKw+0XcwD8BwRg== X-Received: by 2002:a0d:e6d6:: with SMTP id p205-v6mr12910569ywe.9.1524658147122; Wed, 25 Apr 2018 05:09:07 -0700 (PDT) From: Ricardo Giorni Content-Type: multipart/signed; boundary="Apple-Mail=_1096BAC9-0349-4401-9B4B-F62B0810D7EC"; protocol="application/pkcs7-signature"; micalg=sha1 Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: Re: [PATCH] fix backslash added incompatibility after previous patch Date: Wed, 25 Apr 2018 09:09:03 -0300 References: To: zsh-workers@zsh.org In-Reply-To: Message-Id: <90B0A319-7C3D-4E78-9F32-3F5EB1314910@giorni.co> X-Mailer: Apple Mail (2.3445.6.18) --Apple-Mail=_1096BAC9-0349-4401-9B4B-F62B0810D7EC Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On 22 Apr 2018, at 20:45, Ricardo Giorni wrote: >=20 > After patch 42355, escaped backslashes on here-documents stopped = working. >=20 > cat <<-HERE > foo\\ > bar > HERE >=20 > Before patch 42355 (zsh 5.4), and on latest dash and bash: >=20 > foo\ > bar >=20 > After: >=20 > foo\ bar >=20 > =E2=80=94 > Ricardo Adding more background here, after zsh-workers/42355, which updated the = way here docs are processed, some open source configuration scripts that = used to comment last backslash before new line broke. What I did on this patch is move the comparison when a backslash is = found, not when the new line is found. I added some new tests for this = specific scenario. What was changed on 42355 is still working, as the tests added at the = time still shows up. Can someone review it, please? =E2=80=94 Ricardo --Apple-Mail=_1096BAC9-0349-4401-9B4B-F62B0810D7EC Content-Disposition: attachment; filename=smime.p7s Content-Type: application/pkcs7-signature; name=smime.p7s Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIHvDCCB7gw ggWgoAMCAQICEB0xNurlfZVPGFHSXsr8GaQwDQYJKoZIhvcNAQELBQAwdzELMAkGA1UEBhMCQlIx EzARBgNVBAoTCklDUC1CcmFzaWwxNjA0BgNVBAsTLVNlY3JldGFyaWEgZGEgUmVjZWl0YSBGZWRl cmFsIGRvIEJyYXNpbCAtIFJGQjEbMBkGA1UEAxMSQUMgUFJPREVNR0UgUkZCIEc0MB4XDTE3MDcz MTE4NDU1NloXDTE4MDczMTE4NDU1NlowgfAxCzAJBgNVBAYTAkJSMRMwEQYDVQQKDApJQ1AtQnJh c2lsMQswCQYDVQQIDAJNRzEXMBUGA1UEBwwOQmVsbyBIb3Jpem9udGUxNjA0BgNVBAsMLVNlY3Jl dGFyaWEgZGEgUmVjZWl0YSBGZWRlcmFsIGRvIEJyYXNpbCAtIFJGQjEWMBQGA1UECwwNUkZCIGUt Q05QSiBBMTEhMB8GA1UECwwYQXV0ZW50aWNhZG8gcG9yIFBST0RFTUdFMTMwMQYDVQQDDCpSSUNB UkRPIEdVSU1BUkFFUyBHSU9STkkgTUU6MjA4Mjc3NjUwMDAxMDcwggEiMA0GCSqGSIb3DQEBAQUA A4IBDwAwggEKAoIBAQCecld69WYtsepDZRlOoF86y4+MyGWeuo0DeGLpPiym5cD0oV4hgDh4DAlE myf6O3cK+dbEvguTv4upsbP/GkoqLuaL1oxPUjCqLjJHfkwfU593wnOrMZq8NiWClVLgxBk0aDEc mjWiTkvX2MP1dZ32WCZT/USYCGb5bXT8N2IO59DsOPDJ2KnB3iOXeBAvLITE5xevsMG8feGvHJRD HzMSGvLsQyDJEtVp7WDipwarAEAPBHmKsR26/uExhNSBKEfmfEHJPQWf68W0eaQQi3j/6mfylAuW 1UvihPADRPEES596zhaYiUbeCaNfBuK5gB1jChxcLaW9udpC/KSh0vs7AgMBAAGjggLEMIICwDCB tgYDVR0RBIGuMIGroD0GBWBMAQMEoDQEMjI0MDUxOTg2MDE1MjgwNDQ2MzAwMDAwMDAwMDAwMDAw MDAwTUcxMTgyODkxM1NTUE1HoCMGBWBMAQMCoBoEGFJJQ0FSRE8gR1VJTUFSQUVTIEdJT1JOSaAZ BgVgTAEDA6AQBA4yMDgyNzc2NTAwMDEwN6AXBgVgTAEDB6AOBAwwMDAwMDAwMDAwMDCBEXJpY2Fy ZG9AZ2lvcm5pLmNvMAkGA1UdEwQCMAAwHwYDVR0jBBgwFoAU0HhDzIfy/WCuVn3e3YThQZOqDbsw fQYDVR0gBHYwdDByBgZgTAECARcwaDBmBggrBgEFBQcCARZaaHR0cDovL2ljcC1icmFzaWwuY2Vy dGlzaWduLmNvbS5ici9yZXBvc2l0b3Jpby9kcGMvQUNfUFJPREVNR0VfUkZCL0RQQ19BQ19QUk9E RU1HRV9SRkIucGRmMIG6BgNVHR8EgbIwga8wVqBUoFKGUGh0dHA6Ly9pY3AtYnJhc2lsLmNlcnRp c2lnbi5jb20uYnIvcmVwb3NpdG9yaW8vbGNyL0FDUFJPREVNR0VSRkJHNC9MYXRlc3RDUkwuY3Js MFWgU6BRhk9odHRwOi8vaWNwLWJyYXNpbC5vdXRyYWxjci5jb20uYnIvcmVwb3NpdG9yaW8vbGNy L0FDUFJPREVNR0VSRkJHNC9MYXRlc3RDUkwuY3JsMA4GA1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAU BggrBgEFBQcDAgYIKwYBBQUHAwQwbgYIKwYBBQUHAQEEYjBgMF4GCCsGAQUFBzAChlJodHRwOi8v aWNwLWJyYXNpbC5jZXJ0aXNpZ24uY29tLmJyL3JlcG9zaXRvcmlvL2NlcnRpZmljYWRvcy9BQ19Q Uk9ERU1HRV9SRkJfRzQucDdjMA0GCSqGSIb3DQEBCwUAA4ICAQCJ/aQdTlfGCgBqzzamV832dXSD aHFhyUOKstp3+p0ClT+NcJEAIVxVqkAElMbbhYQwjoBRQYJp9e4205as2oGSYVcU0xYYmMOLYD2e qeUorttFDkeFM4tz1zolwhHMh0kH+YJRUrsuiME0Rojg0DM8DNDW4Fl+CUMyhau27vuJ9hrJIktE TdQAdTOxZ3KNYrstWy3ZH5FaediBL+k7XIcxBDR977MjRMPTFBxC0bpYLdOcsGE6f0VYxQ+CgtYU wYGuP+tP+ixR1QL2vu3fVzsOm8EhUqi6Ds2Ye3SezJPIlhWTBWP56vKb7ZLwtCQ2DQKvs5CSOPIb Lr2jNRdQF3VFIMpchISap7hhs5OwJ6QOVxxIaYoJ0/i+JhvpLqWA7DGKU9B2BRwFlFhzQyKkfwxi W6n/7a0Lj8SQpsgSYY7Q4Vxky9VceLEG6Ei6l0RAgqsjv2hoHbq8ujw8m/qrUGtH3ZuOjoJhCYxZ 5RAz3igMIAzcZZn2z8S/2uopiUsCJvsF7KZLuW/zxWKbXeNIivy9OH++vYFl3dBgTQKlgy6cDSvf JPZOmKVw6TK445Alyt5vp4U35kf5g658rMT0ZUbkSQeawlTSoiwuIfZogeJR1JIpIfyUT5Tavc4G lvObCr596mYhMYZzj0z5gJFaEjBtA0mAj1GKqYLPlWmdPNSvzDGCA1QwggNQAgEBMIGLMHcxCzAJ BgNVBAYTAkJSMRMwEQYDVQQKEwpJQ1AtQnJhc2lsMTYwNAYDVQQLEy1TZWNyZXRhcmlhIGRhIFJl Y2VpdGEgRmVkZXJhbCBkbyBCcmFzaWwgLSBSRkIxGzAZBgNVBAMTEkFDIFBST0RFTUdFIFJGQiBH NAIQHTE26uV9lU8YUdJeyvwZpDAJBgUrDgMCGgUAoIIBnTAYBgkqhkiG9w0BCQMxCwYJKoZIhvcN AQcBMBwGCSqGSIb3DQEJBTEPFw0xODA0MjUxMjA5MDRaMCMGCSqGSIb3DQEJBDEWBBRXKBbDHWN9 7UEXbkhZfhi7osG8WzCBnAYJKwYBBAGCNxAEMYGOMIGLMHcxCzAJBgNVBAYTAkJSMRMwEQYDVQQK EwpJQ1AtQnJhc2lsMTYwNAYDVQQLEy1TZWNyZXRhcmlhIGRhIFJlY2VpdGEgRmVkZXJhbCBkbyBC cmFzaWwgLSBSRkIxGzAZBgNVBAMTEkFDIFBST0RFTUdFIFJGQiBHNAIQHTE26uV9lU8YUdJeyvwZ pDCBngYLKoZIhvcNAQkQAgsxgY6ggYswdzELMAkGA1UEBhMCQlIxEzARBgNVBAoTCklDUC1CcmFz aWwxNjA0BgNVBAsTLVNlY3JldGFyaWEgZGEgUmVjZWl0YSBGZWRlcmFsIGRvIEJyYXNpbCAtIFJG QjEbMBkGA1UEAxMSQUMgUFJPREVNR0UgUkZCIEc0AhAdMTbq5X2VTxhR0l7K/BmkMA0GCSqGSIb3 DQEBAQUABIIBABuCXtnCJ/93u9udRpoidZKNh0ngYb9eOXLFDO2w2btPhYbTNWOny9vGocshwoXD wqiWwv1MlUJkX6lPJjoeuM/kXVP6DJxTmbQ4ZMiQrghyDByKkQagXv49lyecUm757MQGlWsXu1Lg kC8Lfal7Xj6SavT7nEg9IfSldeFgbzC9elYIOYUBx3Xo/E74R0qy9+QzzT7y09hqDRsB4QQAQz/E eYNVx+lj1ZMvBf9IPn9L6nTwDY2VMs5hXa4q6E7shl5f3aNl2KEdzxq23gC/HGKiyXeq+Nxm7C6P XvEsTt5JkbHWDIPb7zx3H4WJBxcOV+X6duo+0N36M+YOrVHdiwYAAAAAAAA= --Apple-Mail=_1096BAC9-0349-4401-9B4B-F62B0810D7EC--