From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id E3F282D745 for ; Sun, 8 Sep 2024 17:58:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Message-ID:Date:Content-ID: Content-Type:MIME-Version:Subject:To:References:From:In-reply-to:cc:Reply-To: Content-Transfer-Encoding:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=ekqzNG36ob9c7IeW5I/h2uN4DFNpa+j+K3P0kp6+Gqc=; b=N8ayai31p8tEwGLzhtzvrwMGeN e5zMqlEE/E6n2OI3pXVComl/MafZQmLjwNmqXuaWejcYrrPxJC3whSI5JHI+kYeAbyjOidkMYdAvy ZYf0ba6vrtfObz7ha2CmA55v5zOFYiHInhxwVOn0GCUb+uAQFAqp0LdL/upywvQExPf//Jr6YNAQa VQxrIlJ/hepV7llhKVL1tXkn1bPjZiMgogJxlbIXBYOkHmV0p867AcUyQI89bNVIPo9JAiuxBF4Zs ZLcwZKsrFUweRVE6tZWAX1XW4tClO9rqfcXIFor9TlQ/St0ku+bcsXv2V2jPIDkNaL4uDcdzARIKM JcgLfZjg==; Received: by zero.zsh.org with local id 1snKJP-000K0Y-Mc; Sun, 08 Sep 2024 15:58:51 +0000 Received: by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) id 1snKIc-000Jgt-6L; Sun, 08 Sep 2024 15:58:02 +0000 Received: from [192.168.178.21] (helo=hydra) by mail.kiddle.eu with esmtp(Exim 4.97.1) (envelope-from ) id 1snKIa-00000000OAr-1oFe; Sun, 08 Sep 2024 17:58:00 +0200 cc: zsh-workers@zsh.org In-reply-to: From: Oliver Kiddle References: To: Emil Velikov Subject: Re: Integrating the kmod completions upstream MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <92927.1725811080.1@hydra> Date: Sun, 08 Sep 2024 17:58:00 +0200 Message-ID: <92928-1725811080.428123@V0ZG.ZDVw.IOkd> X-Seq: 53074 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Emil Velikov wrote: > Hello team, I'm considering pulling the zsh completion files (as do > bash and fish fwiw) in the upstream kmod project. This seems to correspond to the Linux _modutils function in zsh. (I guess modutils must have been renamed to kmod at some point) Even if the function stays in zsh, it should be renamed. > At a glance, a few questions come up: > - what is the license of the completion files? Same as the rest of zsh: a variant of the MIT license. > - would the team be comfortable with relicensing under LGPL-2.1-or-later? The LGPL is a superset of the zsh license so from a legal standpoint you can do that. A good portion of the function was written by me and I don't mind it being changed to match any OSI licence of an upstream project wanting to pull their completions in. An alternative you might consider is explicitly dual-licencing the completion file. > - are there any copyright holders which I could/should add in the > files themselves? As a minimum, I would suggest acknowledging in the header that it has been imported from the zsh project, crediting just "Zsh developers". About 15 different people have contributed to that function so naming them all might be a bit much. Or you cut that down to a shorter list. > - is there a particular process/coordination that you'd suggest? Not really, just import the function. Have your build system install the file to $DESTDIR$PREFIX/share/zsh/site-functions and let us know once it reaches a released version of kmod. It's better that there is an overlap period when the function is available from both zsh and kmod than a gap where users get no completion. > In general, would you recommend me going this route, or perhaps it's > better to rewrite them from scratch? Yes, I would recommend that route. In most cases, the upstream project is a better home for completions because they can better track changes in the upstream project. There's no point in duplicating the effort with a rewrite. The completions included with zsh have the advantage of having been written by people who know zsh completion well - if not the kmod project well. Oliver