From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27535 invoked by alias); 15 Feb 2014 17:08:05 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 32386 Received: (qmail 7772 invoked from network); 15 Feb 2014 17:07:59 -0000 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Biglobe-Sender: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Commit 137b15a fails X02zlevi test From: "Jun T." In-Reply-To: <140214174253.ZM10203@torch.brasslantern.com> Date: Sun, 16 Feb 2014 02:07:55 +0900 Content-Transfer-Encoding: 7bit Message-Id: <92A29561-15C5-4282-9CDA-7EDBD4030AE6@kba.biglobe.ne.jp> References: <140208121311.ZM14905@torch.brasslantern.com> <140208144555.ZM16333@torch.brasslantern.com> <140209105343.ZM24252@torch.brasslantern.com> <17919.1391985011@quattro> <140210233703.ZM11806@torch.brasslantern.com> <140212214922.ZM25943@torch.brasslantern.com> <140213093920.ZM27020@torch.brasslantern.com> <140214174253.ZM10203@torch.brasslantern.com> To: zsh-workers@zsh.org X-Mailer: Apple Mail (2.1827) 2014/02/15 10:42, Bart Schaefer wrote: > This is curious. If the collision of the redo binding with the stty > reprint character were relevant, it should cause a problem no matter > when the key binding occurred. That may mean that the real problem > is that ^R is bound to "redisplay" by default ... but then I would > still expect ^K to fail as well, since the implication is that the > comptesteval isn't working properly. I'm not sure whether I have understood your point correctly, but I guess 'bindkey -a "^R" redo' itself isn't causing a trouble. The problem is the '^R' sent by zletest $'123\C-_\e\C-r'. The slave-side zsh should set its tty input into non-canonical mode when Zle is active, but I suspect that it fails (or delays) to do so and the ^R does has a effect of reprint. > Does it really require BOTH > zpty_flush plus and ^K in the FreeBSD case? Yes, both on Mac and FreeBSD. Without the zpty_flush patch, all the tests which use comptesteval fail (unless the test is the 1st test in X02zlevi.ztst). With the zpty_flush patch, only the test with 'bindkey -a "^R" redo' fails. This test succeeds if ^R is replaced by ^K. > What happens if you insert "sleep 1" at the end of comptesteval only? Works on FreeBSD but not on Mac (about 50% failure). I don't know why. But adding 'sleep 1' at the beginning of zletest() seems to work on both Mac and FreeBSD (adding it after the 'zpty_flush Before zletest' is also OK). # Adding 'sleep 1' is to make the last failing test (^R-redo test) to # succeed (with zpty_flush patch applied but redo is bound to ^R). > Actually for my own system I can *remove* _all_ zpty_flush calls from > zle_test and it still works. Maybe the only call of zpty_flush necessary is 'zpty_flush After comptesteval' in comptesteval(); all the other zpty_flush call can be removed. With this single call of zpty_flush and ^R --> ^K, all the test pass on Mac and FreeBSD (without adding sleep anywhere).