From: dana <dana@dana.is>
To: Zsh workers <zsh-workers@zsh.org>
Subject: [PATCH] Completion: Always offer -F/-m for `git tag`
Date: Fri, 4 Jan 2019 14:55:16 -0600 [thread overview]
Message-ID: <93238DA8-B160-4CAB-BDE6-9AB029E23311@dana.is> (raw)
Another thing i noticed whilst following the release instructions, thought i
might as well fix it before going on:
_git-tag doesn't offer -F/-m unless -a/-s/-u are already provided, but this
isn't necessary or helpful; the man page for `git tag` says that -F/-m without
-a/-s/-u implies -a.
dana
diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git
index 093464625..0ebbbe861 100644
--- a/Completion/Unix/Command/_git
+++ b/Completion/Unix/Command/_git
@@ -2017,15 +2017,6 @@ _git-subtree () {
(( $+functions[_git-tag] )) ||
_git-tag () {
- local -a message_opts
-
- if (( words[(I)-[asu]] )); then
- message_opts=(
- '(-m --message -F --file)'{-m+,--message=}'[specify tag message]:message'
- '(-m --message -F --file)'{-F+,--file=}'[read tag message from given file]:message file:_files'
- )
- fi
-
_arguments \
- creation \
'(-a --annotate -s --sign -u --local-user)'{-a,--annotate}'[create an unsigned, annotated tag]' \
@@ -2035,7 +2026,8 @@ _git-tag () {
'(-f --force)'{-f,--force}'[replace existing tag]' \
'--create-reflog[create a reflog]' \
'--cleanup=[cleanup message]:mode:((verbatim\:"no cleanup" whitespace\:"remove leading and trailing whitespace" strip\:"remove leading and trailing whitespace and comments"))' \
- $message_opts \
+ '(-m --message -F --file)'{-F+,--file=}'[read tag message from given file]:message file:_files' \
+ '(-m --message -F --file)'{-m+,--message=}'[specify tag message]:message' \
': :__git_tags' \
':: :__git_commits' \
- deletion \
reply other threads:[~2019-01-04 20:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93238DA8-B160-4CAB-BDE6-9AB029E23311@dana.is \
--to=dana@dana.is \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).