From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY
	autolearn=ham autolearn_force=no version=3.4.4
Received: (qmail 25864 invoked from network); 11 Nov 2021 17:09:05 -0000
Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368)
  by inbox.vuxu.org with ESMTPUTF8; 11 Nov 2021 17:09:05 -0000
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org;
	s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:
	List-Subscribe:List-Help:List-Id:Sender:Message-ID:Date:
	Content-Transfer-Encoding:Content-ID:Content-Type:MIME-Version:Subject:To:
	References:From:In-reply-to:cc:Reply-To:Content-Description:Resent-Date:
	Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID;
	bh=gW6VCgEVRMAsDo3OQ8yaCCHw6eJ0DM8C5IeZH6EkU2Y=; b=hsRBcqD1Et+oKVbm4LsjkE1gtk
	brV2WGtGgLA4tVMU9z0aD/Aq+z6AclPqeiZcijHKeNQWk+PE0EaX4EcJJuHlPaNs1/ZzjYm9TPmct
	jSCkPBjplTNaGBORjcN7klQl052CFcGLmZSovkAHMeNe0mu2VIsEET93WvvvxBg0AS7MbTVQNfkvc
	sB7ICnweoP+6TrTK1Tmq074tAWe0v7dmhFhn5LKt2cw4Vl/Hxg1GZ2kloztr0S8t0czbOIm+ziLHI
	2Lyq92SyC2uPbmlYpb7UFXgFaUyXu1mBujKVCGPbmnWW+b+RxtHdNc/HN3AcBEhFHr91rgQ8GuJew
	78Cwxinw==;
Received: from authenticated user by zero.zsh.org with local 
	id 1mlDZP-0003Lb-L4; Thu, 11 Nov 2021 17:09:03 +0000
Received: from authenticated user by zero.zsh.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256)
	id 1mlDYt-000353-Md; Thu, 11 Nov 2021 17:08:31 +0000
Received: from [192.168.178.21] (helo=hydra)
	by mail.kiddle.eu with esmtp(Exim 4.94.2)
	(envelope-from <opk@zsh.org>)
	id 1mlDYs-000ORm-T3; Thu, 11 Nov 2021 18:08:31 +0100
cc: zsh-workers@zsh.org
In-reply-to: <F80A0CEA-3C20-491E-B15B-1ECC544ABE8F@kba.biglobe.ne.jp>
From: Oliver Kiddle <opk@zsh.org>
References: <41833-1635545739.955327@NiDy.UqMC.wWcd> <F80A0CEA-3C20-491E-B15B-1ECC544ABE8F@kba.biglobe.ne.jp>
To: Jun T <takimoto-j@kba.biglobe.ne.jp>
Subject: Re: PATCH: separate watch/log functionality out into a module
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <93976.1636650510.1@hydra>
Content-Transfer-Encoding: 8bit
Date: Thu, 11 Nov 2021 18:08:30 +0100
Message-ID: <93977-1636650510.897657@B71Q.U4fb.k4DR>
X-Seq: 49565
Archived-At: <https://zsh.org/workers/49565>
X-Loop: zsh-workers@zsh.org
Errors-To: zsh-workers-owner@zsh.org
Precedence: list
Precedence: bulk
Sender: zsh-workers-request@zsh.org
X-no-archive: yes
List-Id: <zsh-workers.zsh.org>
List-Help: <mailto:sympa@zsh.org?subject=help>
List-Subscribe: <mailto:sympa@zsh.org?subject=subscribe%20zsh-workers>
List-Unsubscribe: <mailto:sympa@zsh.org?subject=unsubscribe%20zsh-workers>
List-Post: <mailto:zsh-workers@zsh.org>
List-Owner: <mailto:zsh-workers-request@zsh.org>
List-Archive: <http://www.zsh.org/sympa/arc/zsh-workers>

Jun T wrote:
>
> With this patch (either with or without the one in worker/49544⁩),
> build fails on Cygwin as follows:

Thanks for catching this.

> A simple workaround is to set the .gsu in the setup_() function.
> This takes virtually no time to execute and I think we don't need to use
> #ifdef __CYGWIN__.

That sounds reasonable to me.

That is assuming I didn't get something wrong when tagging visibility
on the structs and their members. I wouldn't have complete faith in
the build system to adapt to those changes so, if you didn't already,
start with an absolutely clean build.

colonarr_gsu did change from static to mod_export along with the get and
set function it includes. vararray_gsu didn't change other than in
being referenced from a module. Looking for other examples, I'm not
really finding any. Modules otherwise only include variables with
access functions that are unique to them.

Oliver