zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: "Wu, Zhenyu" <wuzhenyu@ustc.edu>, zsh-workers@zsh.org
Subject: Re: Bug: Unicode character of zsh module will become weird characters
Date: Mon, 13 May 2024 10:51:18 +0100 (BST)	[thread overview]
Message-ID: <941766233.1602619.1715593878048@mail.virginmedia.com> (raw)
In-Reply-To: <t6jmrshbviujvvb4i3doaaqbo52bwccx2e27v2fgyvitx22x43@tkgdvxkrays5>

> On 11/05/2024 14:40 BST Wu, Zhenyu <wuzhenyu@ustc.edu> wrote:
> ```zsh
> % git clone --depth=1 https://github.com/zsh-users/zsh
> % cd zsh
> % sed -i 's/strparam = ztrdup("example");/strparam = ztrdup("你好");/' Src/Modules/example.c
> % autoreconf -vif
> % ./configure
> % make
> ```

I think The problem's actually here.  Zsh has a special encoding of
strings internally to avoid confusion between normal strings and
tokenised strings.  This is because special characters are mixed in with
normal characters in strings inside the code.  This system is known as
"metafication".  This means you have to be careful when creating strings
to be stored inside the system.  In fact, this is usually only a problem
if strings contain byte 0x80, so it can be a bit of a surprise when you
see it.

If you're doing normal input and output this should work automatically,
but you're updating the source code directly.  Try changing the line in
the example file to:

    strparam = metafy("你好", strlen("你好"), META_DUP);

and see if that works --- looks OK to me with a quick test.

cheers
pws


      reply	other threads:[~2024-05-13  9:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-11 13:40 Wu, Zhenyu
2024-05-13  9:51 ` Peter Stephenson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=941766233.1602619.1715593878048@mail.virginmedia.com \
    --to=p.w.stephenson@ntlworld.com \
    --cc=wuzhenyu@ustc.edu \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).