zsh-workers
 help / color / mirror / code / Atom feed
From: hzoli@cs.elte.hu (Zoltan Hidvegi)
To: zsh-workers@math.gatech.edu (zsh-workers)
Subject: Re: Bugfix: zsh crashes if invoked with unset PATH
Date: Fri, 7 Jul 1995 17:22:00 +0100 (MET DST)	[thread overview]
Message-ID: <9507071522.AA15820@turan.elte.hu> (raw)
In-Reply-To: <9507050940.AA05399@turan.elte.hu> from "Zoltan Hidvegi" at Jul 5, 95 11:40:23 am

I posted this a few days ago:
> 
> If PATH is not set in the environment, zsh dumps core the first time it
> attempts to execute an external command without an absolute path. That is
> because in init.c newcmdnamtable() is called before the path is initialised.
> 
> % unset PATH ; ./zsh -fc 'ls'            
> zsh: 5275 segmentation fault (core dumped)  ./zsh -fc 'ls'
> 
> Because of this bug one of my boot scripts faild (that's almost the only place
> where PATH is unset).
> 
> Here is the patch to fix that. It applies with fuzz 2 to the baseline zsh as I
> added /usr/local/bin to the default path in my release.

Unfortunately, I forgot to include the patch to fix that. It's funny that
noone complained.

Here it is now.

Bye,
  Zoltan

rcsdiff -qc -kk -r1.7 -r1.8 Src/init.c
*** Src/init.c
--- Src/init.c	1995/07/05 11:39:28
***************
*** 452,458 ****
  
      newreswdtable();    /* create hash table for reserved words */
      newaliastable();    /* create hash table for aliases        */
-     newcmdnamtable();   /* create hash table for commands       */
      newcompctltable();  /* create hash table for compctls       */
  
      initxbindtab();  /* initialize key bindings */
--- 452,457 ----
***************
*** 542,548 ****
      path[3] = ztrdup("/usr/local/bin");
      path[4] = NULL;
  
!     inittyptab();     /* initialize the ztypes table */
      initlextabs();
  
      /* We cache the uid so we know when to *
--- 541,548 ----
      path[3] = ztrdup("/usr/local/bin");
      path[4] = NULL;
  
!     newcmdnamtable();   /* create hash table for commands       */
!     inittyptab();       /* initialize the ztypes table          */
      initlextabs();
  
      /* We cache the uid so we know when to *


      reply	other threads:[~1995-07-07 15:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1995-07-05 10:40 Zoltan Hidvegi
1995-07-07 16:22 ` Zoltan Hidvegi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9507071522.AA15820@turan.elte.hu \
    --to=hzoli@cs.elte.hu \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).