From: Richard Coleman <coleman@math.gatech.edu>
To: hzoli@cs.elte.hu, pws@ifh.de
Cc: zsh-workers@math.gatech.edu
Subject: Re: still bugs with 8-bit chars :-(
Date: Wed, 18 Oct 1995 00:42:49 -0400 [thread overview]
Message-ID: <9510180442.AA24279@redwood.skiles.gatech.edu> (raw)
In-Reply-To: Your message of "Tue, 17 Oct 1995 16:02:16 BST." <199510171502.QAA27274@bolyai.cs.elte.hu>
> However, Peter's patch is not perfect, since it uses a cast from char to
> unsignec char, which is broken with some compilers. Here is a fix for that.
> If you have a buggy compiler, this may be your problem.
>
>
> *** 1.2 1995/10/10 18:20:38
> --- Src/input.c 1995/10/17 14:57:56
> ***************
> *** 109,115 ****
> if (inbufleft) {
> inbufleft--;
> inbufct--;
> ! return lastc = (int)(unsigned char)*inbufptr++;
> }
> /*
> * No characters in input buffer.
> --- 109,115 ----
> if (inbufleft) {
> inbufleft--;
> inbufct--;
> ! return lastc = STOUC(*inbufptr++);
> }
> /*
> * No characters in input buffer.
>
Since we already casting anyway, wouldn't the line
return lastc = (int)(unsigned short)*inbufptr++;
do just as well. I don't ever use 8-bit characters, so I not
positive about this.
rc
next prev parent reply other threads:[~1995-10-18 4:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
1995-10-17 12:46 Carlos Carvalho
1995-10-17 15:02 ` Zoltan Hidvegi
1995-10-17 21:48 ` Carlos Carvalho
1995-10-18 4:42 ` Richard Coleman [this message]
1995-10-18 12:47 ` Zoltan Hidvegi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9510180442.AA24279@redwood.skiles.gatech.edu \
--to=coleman@math.gatech.edu \
--cc=hzoli@cs.elte.hu \
--cc=pws@ifh.de \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).