From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: Marlon Richert <marlon.richert@gmail.com>,
Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Bug report: Completion for dynamically named dirs fails when $SUFFIX is not empty
Date: Wed, 31 Mar 2021 09:56:11 +0100 (BST) [thread overview]
Message-ID: <953623758.933579.1617180972000@mail2.virginmedia.com> (raw)
In-Reply-To: <CAHLkEDu6+Jsy23CVtghH1J5V1mM56oE0Vrw9Eb7j_VoYS2BJYA@mail.gmail.com>
> On 31 March 2021 at 09:37 Marlon Richert <marlon.richert@gmail.com> wrote:
> On Wed, Mar 31, 2021 at 11:29 AM Marlon Richert
> <marlon.richert@gmail.com> wrote:
> >
> > On Wed, Mar 31, 2021 at 11:25 AM Peter Stephenson
> > <p.w.stephenson@ntlworld.com> wrote:
> > > > On 31 March 2021 at 09:10 Marlon Richert <marlon.richert@gmail.com> wrote:
> > > > Could someone please review Peter's patch, below?
> > >
> > > This change is already in.
> >
> > Really? I don't see it in Src/Zle/zle_main.c on the master branch.
>
> You are right that the other changes are in. Sorry, I only checked
> `git log -L 1060,1100:Src/Zle/zle_main.c` and when that failed to show
> any changes, I assumed that the whole patch had not been applied yet.
>
> However, why apply only the changes in the other files and not the one
> in Src/Zle/zle_main.c ? Is that intentional or an oversight?
Apologies, that was intentional because I realised the diff I sent included
some old stuff which actually wasn't needed. The zle_main.c chunk in the
patch is irrelevant to the fix.
pws
next prev parent reply other threads:[~2021-03-31 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 14:37 Marlon Richert
2021-01-25 15:07 ` Peter Stephenson
2021-03-31 8:10 ` Marlon Richert
2021-03-31 8:25 ` Peter Stephenson
2021-03-31 8:29 ` Marlon Richert
2021-03-31 8:37 ` Marlon Richert
2021-03-31 8:56 ` Peter Stephenson [this message]
2021-05-07 14:08 ` [BUG] COMPLETE_IN_WORD fails to recognize brace_parameter context Marlon Richert
2021-05-08 0:04 ` Bart Schaefer
2021-05-08 13:04 ` Marlon Richert
2021-05-08 4:37 ` Bart Schaefer
2023-02-22 11:55 ` Bug report: Completion for dynamically named dirs fails when $SUFFIX is not empty Marlon Richert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=953623758.933579.1617180972000@mail2.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=marlon.richert@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).