From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 19988 invoked from network); 31 Mar 2021 08:56:36 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 31 Mar 2021 08:56:36 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1617180996; b=df2P0js0Gwjo5qRXxTbLAH+wQKQ/jdxr3WbG2oZDDRsZy76GtIPOObLy6ygjcfQq/3wlUUdsbn NTRFow4NRiGb9gAg0pHhNKx8lmZhCNuWiU1Q8fkqAFphDVKc5JQsd7AOZb9mTEIm5CzcK3fy4z giVNY5h5Efn3o2QPQvDU3gR8QzT44XiqKSN9i3SY7Cr1e16BVvbUoRq1BK73EXUEoLtnyG7fTa Y9FhgmevA3OPxgpCq5T/0VwAB+vjUVMRLHvgGb3e3sqadmi3l1LvQ90RMP103eXAxMPQC+YieK JftaXunlKkvCB0WDMjOUt+z0hMJBzejwphaxA8i/hpoAdQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (smtpq2.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.97; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1617180996; bh=Q1z/RDVvpCAkakGr6/KpKL+ZkXb319iMQtGtBHWOfUU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:To:From:Date:DKIM-Signature: DKIM-Signature; b=b2s+1typyoJ5QzOaV1fpQLAjZooggxMOln8h32RifEfLienjwVcSpg+FJ4nROukHAJdOIhVMnT XH3elggCcFyIWP7NdLATbf09QYXQKguzPCg3saoGuZqMW1WXQIw4+DSGTFAZZ7DpKG4VoyWBIt AuLdqmTCw3K4bzfCeoCnMnur8+q4AQfPqHeBEKDimkbmiwPG4sslpAd/xYAV6yzfa6AJb7b5Jt Wtd4ZbWNimKmgXGNMXoU6eGrTXlykymSSJkg+KUEjfc2l+kjhdRbj1TujThwG4cGo7LLaWXj1s IGQ6hMhsp9fHYwP12g/Mp+heuQXzc4R6qoSF1ua+Mp35Vw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Subject:References:In-Reply-To:Message-ID:To:From: Date:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=ScU3STmRLQFY835317fu+YtOM0Ji3oIyYJQIaqQQ/9c=; b=HTOXDOvzprQIXZsvSPpeaRcleu 9WKC4KrflAJnfGTTd8wFArStB+KBXgZ0HJcAfGipF2Bz60WO7gLwDvGieAdkTAJVyzNa/Zdgt3Vd8 qcZoXbEd7ZAuhuex1BCVRXU0o3rILt/D8sWojYNR81GTLrJZZN0uLraBoW5RVExIyymPAR76H2DAt 5U2jspwuIYoTBBqlDjXukyTd8VcQkc/jtGibMcc+QiIiboV7B0+zANzaOatOF6AL6SkN07Erwxqn8 5qFqS+MyYNNDba4q9I0lV1Tkj278PgGwGG1weOG/zSmnWiM0cqAH/l3i0d8941aASACVqPIkh8tFD HW3qeLFg==; Received: from authenticated user by zero.zsh.org with local id 1lRWeN-000Fqq-Ja; Wed, 31 Mar 2021 08:56:31 +0000 Authentication-Results: zsh.org; iprev=pass (smtpq2.tb.ukmail.iss.as9143.net) smtp.remote-ip=212.54.57.97; dkim=pass header.d=ntlworld.com header.s=meg.feb2017 header.a=rsa-sha256; dmarc=pass header.from=ntlworld.com; arc=none Received: from smtpq2.tb.ukmail.iss.as9143.net ([212.54.57.97]:54178) by zero.zsh.org with esmtps (TLS1.2:ECDHE-RSA-AES128-GCM-SHA256:128) id 1lRWe4-000FiN-EX; Wed, 31 Mar 2021 08:56:13 +0000 Received: from [212.54.57.82] (helo=smtp3.tb.ukmail.iss.as9143.net) by smtpq2.tb.ukmail.iss.as9143.net with esmtp (Exim 4.86_2) (envelope-from ) id 1lRWe4-0003Bx-90 for zsh-workers@zsh.org; Wed, 31 Mar 2021 10:56:12 +0200 Received: from oxbe3.tb.ukmail.iss.as9143.net ([172.25.160.134]) by smtp3.tb.ukmail.iss.as9143.net with ESMTP id RWe4ldV0niCtJRWe4lLx2h; Wed, 31 Mar 2021 10:56:12 +0200 X-Env-Mailfrom: p.w.stephenson@ntlworld.com X-Env-Rcptto: zsh-workers@zsh.org X-SourceIP: 172.25.160.134 X-CNFS-Analysis: v=2.4 cv=GushRm5C c=1 sm=1 tr=0 ts=6064392c cx=a_exe a=rX2mKgs1IZJU9lF6pltyEQ==:117 a=DeGUKtW0en8A:10 a=IkcTkHD0fZMA:10 a=zAZwVUNnDPoA:10 a=pGLkceISAAAA:8 a=NLZqzBF-AAAA:8 a=wqLx8iRu8qnIpzGAJUwA:9 a=QEXdDO2ut3YA:10 a=wW_WBVUImv98JQXhvVPZ:22 X-Authenticated-Sender: p.w.stephenson@ntlworld.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ntlworld.com; s=meg.feb2017; t=1617180972; bh=Q1z/RDVvpCAkakGr6/KpKL+ZkXb319iMQtGtBHWOfUU=; h=Date:From:To:In-Reply-To:References:Subject; b=0wiL8XgL38FRjZYAMryrdV1s+5UfUN7SVtHUdpLIrjc1ceji+5nzb+sn+WQ51ylTD zB1gyEGgLz80qdC+70qxGGm37fgnzLtRxjyZcTp1vNUhJq93P1XGGd1VRefDyKCbFr j1YwiXYiZowEFeV5EUYaHWKIQIGhyS8zvyYMfNBgHeHr1IyYLihFbZLZpRwfd2LsUm h0ZfxoSDWFiZun+U/5TVfeUR3iZSyCyFeJEEcJ8cZUuB+fBNnhPniJtqpUqbLqfnA0 8aT2c4V2InINql4S6l7GL06cL+jT7fdG69IJmWS5BQfuo5oNZuf8ISdDiR0qOmSUKY YyqEBGUL9kf7Q== Date: Wed, 31 Mar 2021 09:56:11 +0100 (BST) From: Peter Stephenson To: Marlon Richert , Zsh hackers list Message-ID: <953623758.933579.1617180972000@mail2.virginmedia.com> In-Reply-To: References: <1857440792.3267285.1611587238431@mail2.virginmedia.com> <1870412799.932334.1617179102623@mail2.virginmedia.com> Subject: Re: Bug report: Completion for dynamically named dirs fails when $SUFFIX is not empty MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.4-Rev72 X-Originating-IP: 165.225.81.25 X-Originating-Client: open-xchange-appsuite X-CMAE-Envelope: MS4xfDEh7n06bgzchxLQiJq7sRt7lg53ZogdfTLCDoNa/Y7+EDlDd5c9NON/j4Ne9fGxwDL2K+2nd+hnyEPr6WQ7taxMG41hS0nxoVPI2u+0IyNRIJ+MkzpC 3f4464zxHuWoZ+WhLhmNw+Q+vcQzyY1Yn/Gs07mARVw5P7fp3dInkIYbvUT30OqYCGmwIVbbA5oLSgFMezIl+5gdE+CC+hw8hC285fZvEt5Dxtya/cMhMWHn nQTBgb+WaMglxONzGzTZMEz9KJpfzEdii7bpDPsMj6Y= X-Seq: 48348 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: > On 31 March 2021 at 09:37 Marlon Richert wrote: > On Wed, Mar 31, 2021 at 11:29 AM Marlon Richert > wrote: > > > > On Wed, Mar 31, 2021 at 11:25 AM Peter Stephenson > > wrote: > > > > On 31 March 2021 at 09:10 Marlon Richert wrote: > > > > Could someone please review Peter's patch, below? > > > > > > This change is already in. > > > > Really? I don't see it in Src/Zle/zle_main.c on the master branch. > > You are right that the other changes are in. Sorry, I only checked > `git log -L 1060,1100:Src/Zle/zle_main.c` and when that failed to show > any changes, I assumed that the whole patch had not been applied yet. > > However, why apply only the changes in the other files and not the one > in Src/Zle/zle_main.c ? Is that intentional or an oversight? Apologies, that was intentional because I realised the diff I sent included some old stuff which actually wasn't needed. The zle_main.c chunk in the patch is irrelevant to the fix. pws