From: dana <dana@dana.is>
To: Matthew Martin <phy1729@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: Add chmod builtin
Date: Sun, 17 Mar 2019 20:28:06 -0500 [thread overview]
Message-ID: <95E69303-E47F-43BD-9BA6-22C6A8652C2A@dana.is> (raw)
In-Reply-To: <CAGnh9tAP0eco+_qQb6nyx3QRFwqP+XMD=WmQayAXBNz5jm7zqw@mail.gmail.com>
On 17 Mar 2019, at 19:44, Matthew Martin <phy1729@gmail.com> wrote:
>Reading the docs for _pick_variant, there's a -b option to detect
>builtins. It has some issues (namely with precommands), but those can be
>fixed in a separate commit. Requires some reindenting, so I've split the
>patch in two.
Yeah, that works for me. Just the $precommands stuff is an issue, and i like
your idea for incorporating that into -b; AFAIK, if we do another pass on
that afterwards, we can then rip out all of the explicit $precommands checks
in _stat and every other function
dana
prev parent reply other threads:[~2019-03-18 1:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-17 3:08 Matthew Martin
2019-03-17 11:27 ` dana
2019-03-18 0:44 ` Matthew Martin
2019-03-18 1:28 ` dana [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95E69303-E47F-43BD-9BA6-22C6A8652C2A@dana.is \
--to=dana@dana.is \
--cc=phy1729@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).