From: Kamil Dudka <kdudka@redhat.com>
To: Bart Schaefer <schaefer@brasslantern.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH] mkenvstr: avoid crash in case NULL is given as value
Date: Wed, 20 May 2015 20:17:30 +0200 [thread overview]
Message-ID: <9615546.qODALlRzib@kdudka.brq.redhat.com> (raw)
In-Reply-To: <13142758.yMuWt9XIhO@kdudka.brq.redhat.com>
On Wednesday 20 May 2015 19:35:13 Kamil Dudka wrote:
> On Wednesday 20 May 2015 10:23:00 Bart Schaefer wrote:
> > On May 20, 4:43pm, Kamil Dudka wrote:
> > }
> > } Good catch! Then your patch certainly looks as a better choice to me.
> >
> > It belatedly occurs to me that adding
> >
> > if (!value)
> >
> > value = "";
> >
> > would have been a sufficient change. Oh, well.
>
> I am quite new to zsh code but this drives me to a question: Are the strings
> allocated in mkenvstr() freed anywhere?
Oops, it is a misleading question anyway. It would return an allocated string
in both cases. Sorry for the noise.
> Kamil
prev parent reply other threads:[~2015-05-20 18:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 18:24 Kamil Dudka
2015-05-19 23:12 ` Bart Schaefer
2015-05-20 14:43 ` Kamil Dudka
2015-05-20 17:23 ` Bart Schaefer
2015-05-20 17:35 ` Kamil Dudka
2015-05-20 18:17 ` Kamil Dudka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9615546.qODALlRzib@kdudka.brq.redhat.com \
--to=kdudka@redhat.com \
--cc=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).