From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17410 invoked from network); 6 Mar 1997 19:58:36 -0000 Received: from euclid.skiles.gatech.edu (list@130.207.146.50) by coral.primenet.com.au with SMTP; 6 Mar 1997 19:58:36 -0000 Received: (from list@localhost) by euclid.skiles.gatech.edu (8.7.3/8.7.3) id OAA27107; Thu, 6 Mar 1997 14:48:17 -0500 (EST) Resent-Date: Thu, 6 Mar 1997 14:48:17 -0500 (EST) From: (Zoltan T. Hidvegi) Message-Id: <9703061858.AA14334@lotto.fishkill.ibm.com> Subject: Re: zle_refresh patch 2 In-Reply-To: <970305165110.ZM7569@candle.brasslantern.com> from Bart Schaefer at "Mar 5, 97 04:51:10 pm" To: schaefer@nbn.com Date: Thu, 6 Mar 1997 13:58:10 -0500 (EST) Cc: zsh-workers@math.gatech.edu (Zsh workers list) X-Mailer: ELM [version 2.4ME+ PL31 (25)] Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Resent-Message-ID: <"HlIA23.0.Ud6.0-n7p"@euclid> Resent-From: zsh-workers@math.gatech.edu X-Mailing-List: archive/latest/2967 X-Loop: zsh-workers@math.gatech.edu Precedence: list Resent-Sender: zsh-workers-request@math.gatech.edu Bart Schaefer wrote: > Hmm. Well, I dislike your change because it presumes that init_term() > is independent of the values of "lines" and "columns". This in itself > (init_term() not knowing about lines/columns) MAY be wrong, now that I > look at it, because init_term() is called from zle in a couple places, > namely putprompt() and zleread(). > > Will zle ever call init_term in such a way that a very-small terminal is > set incorrectly? I don't follow it well enough to be sure. zle calls init_term only if !termok holds, so it may cause a problem when COLUMNS < 3. But here the meaning of termok should be changed. It should contain flags, like TERM_BAD, TERM_NOUP, TERM_UNKNOWN, TERM_SHORT, TERM_NARROW, etc. init_term() should only be called if TERM_UNKNOWN is true. Line/column change should only change some flags in termok. Zoltan