From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: gwing@primenet.com.au, zsh-workers@math.gatech.edu (zsh-workers)
Subject: Re: Zle patch - termok change
Date: Fri, 7 Mar 1997 01:43:59 -0800 [thread overview]
Message-ID: <970307014359.ZM12055@candle.brasslantern.com> (raw)
In-Reply-To: gwing@primenet.com.au "Zle patch - termok change" (Mar 7, 6:23pm)
On Mar 7, 6:23pm, gwing@primenet.com.au wrote:
} Subject: Zle patch - termok change
}
} termok now is flag based, not value based.
} termok == 0 indicates a `normal' working terminal - this is *opposite* to
} the previous situation.
In that case, you should never use the form (!termok) because it reads as
if you mean the terminal is not OK. Use (termok == 0) or make a new macro
#define nosetflag(X) ((X) == 0)
and then write (nosetflag(termok)).
} Flags for termok are defined and explained in zsh.h - currently TERM_NARROW
} is unused.
It looks like it is used in zlevarsetfn() ... you mean nobody explicitly
tests for it, but it is used in the sense that it makes termok != 0 ...
} If a terminal is evaluated as TERM_BAD then that status shouldn't go until
} $TERM is changed.
So that means that init_term() looks for TERM_BAD and doesn't change it?
Or what?
} Bart wrote:
} :Hmm. Well, I dislike ..... because it presumes that init_term()
} :is independent of the values of "lines" and "columns".
}
} I can't see why lines/columns should be any way connected to init_term() .
They don't need to be as long as init_term() doesn't reset TERM_SHORT or
TERM_NARROW. If I do
TERM=vt100
LINES=3
COLUMNS=3
TERM=xterm
Then what happens to termok? Am I going to get a crash because init_term()
has reset termok to zero?
BTW:
#define issetflag(X, Y) ((X & (Y)) == Y)
#define isanysetflag(X, Y) (X & (Y))
Is it really necessary for these to be different? Why risk evaluating Y
twice in issetflag?
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.nbn.com/people/lantern
next prev parent reply other threads:[~1997-03-07 9:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1997-03-07 7:23 gwing
1997-03-07 9:43 ` Bart Schaefer [this message]
1997-03-07 14:03 ` gwing
1997-03-08 0:14 ` Zoltan T. Hidvegi
1997-03-07 15:03 ` Zefram
[not found] <5fpbgb$lsm$1@coral.primenet.com.au>
1997-03-08 12:19 ` G C Wing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=970307014359.ZM12055@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=gwing@primenet.com.au \
--cc=schaefer@nbn.com \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).