From: <hzoli@VNET.IBM.COM> (Zoltan T. Hidvegi)
To: zsh-workers@math.gatech.edu (Zsh workers list)
Subject: Re: Bug in 3.1.2-beta compared with -test1
Date: Wed, 4 Jun 1997 13:16:37 -0400 (EDT) [thread overview]
Message-ID: <9706041716.AA21360@belgium.fishkill.ibm.com> (raw)
In-Reply-To: <199706041601.SAA07220@hydra.ifh.de> from Peter Stephenson at "Jun 4, 97 06:01:08 pm"
Peter Stephenson wrote:
> Bruce Stephens wrote:
> > "sleep 1&" returns (or some other background job), some stty settings seem
> > wrong: eof, susp, etc., get zapped. I've never noticed this in previous
>
> Any advance on the following patch? inforeground seems to me to be
> the minimum you would need to do before grabbing the tty settings, so
> this can't be far wrong. It seems to do the trick, anyway.
Yes, this patch seems to be OK. Unfortunately the same bug is in zsh-3.0.3
so I may have to release zsh-3.0.4 with this one line fix. The original
condition in zsh-3.1.1 was
pgrp = gettygrp(); /* get process group of tty */
/* is this job in the foreground of an interactive shell? */
if ((jn->gleader == pgrp || (pgrp > 1 && kill(-pgrp, 0) == -1)) &&
!ttyfrozen && !val && !jn->stty_in_env)
gettyinfo(&shttyinfo);
Looks horrible, that cannot be right. I did not notice this bug since I
use ttyctl -f.
That whole job control stuff looks like noone had any clue how it works so
everyone just put in more and more conditions until it seemd to work. I
still do not fully understand everything here, but hopefully things are
better now.
Zoltan
next prev parent reply other threads:[~1997-06-04 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
1997-06-04 13:34 Bruce Stephens
1997-06-04 16:01 ` Peter Stephenson
1997-06-04 16:12 ` Bruce Stephens
1997-06-04 17:15 ` Bart Schaefer
1997-06-04 17:16 ` Zoltan T. Hidvegi [this message]
1997-06-04 18:18 ` Geoff Wing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9706041716.AA21360@belgium.fishkill.ibm.com \
--to=hzoli@vnet.ibm.com \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).