From: suzuki@otsl.oki.co.jp (SUZUKI Hisao)
To: hzoli@ny.frontiercomm.net
Cc: zsh-workers@math.gatech.edu
Subject: Re: zsh-3.0.3: another problem in Src/jobs.c
Date: Fri, 20 Jun 97 08:32:48 JST [thread overview]
Message-ID: <9706192332.AA00517@oz.fantasy.otsl.oki.co.jp> (raw)
In-Reply-To: <199706190704.DAA05872@hzoli.home> (message from Zoltan Hidvegi on Thu, 19 Jun 1997 03:04:03 -0400 (EDT))
>> Jo napot kivanok!
>> (...or "Jo reggelt kivanok")
>
>Just for those, who do not speak Hungarian, these are just greetings
>meaning good day and good morning :-). Where did you learn these (I'm
>just curious)?
I am an admirer of Kodaly and Bartok, who were both Hungarian
composers in (early) 20th century music, so I have been learning
Hungarian in hope of understanding their works thoroughly (and I
found it a very interesting language, which somewhat resembles
Japanese in several respects...)
By the way,
[snip]
>Here is Peter's patch:
>
>*** ./Src/jobs.c.old Wed Jun 4 17:51:43 1997
>--- ./Src/jobs.c Wed Jun 4 17:53:39 1997
[snip]
>! if (shout && !ttyfrozen && !jn->stty_in_env && inforeground)
> gettyinfo(&shttyinfo);
[snip]
Aha! A simple and elegant patch! I am slightly worried since
it does not check the process group, but actually it seems to be
working very well.
However, I noticed a little bug (or, at least, a singular
behavior) just now. The variable "inforeground" referred in the
patch will not be set true if the last command in a pipeline is
in the current shell. Hence, though it is artificial,
% stty erase ^H | :
has no effect since the last command is a shell builtin ":",
whereas
% stty erase ^H | cat
will modify the tty setting since the last command is "cat".
I do not think whether the last command is in the shell or not
should be relevant in this case. The following patch would be
better:
----------------------------------------------------------------
*** zsh-3.0.3/Src/jobs.c.ORIG Tue Jun 3 05:11:27 1997
--- zsh-3.0.3/Src/jobs.c Thu Jun 19 16:37:42 1997
***************
*** 154,160 ****
}
}
! if (shout && !ttyfrozen && !jn->stty_in_env)
gettyinfo(&shttyinfo);
if (isset(MONITOR)) {
--- 154,160 ----
}
}
! if (shout && !ttyfrozen && !jn->stty_in_env && !somestopped && job == thisjob)
gettyinfo(&shttyinfo);
if (isset(MONITOR)) {
----------------------------------------------------------------
Regards,
Hisao Suzuki <suzuki@otsl.oki.co.jp>
next prev parent reply other threads:[~1997-06-19 23:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
1997-06-19 6:24 SUZUKI Hisao
1997-06-19 7:04 ` Zoltan Hidvegi
1997-06-19 7:26 ` Andrei Tcherepanov
1997-06-19 8:24 ` Patch for zle_refresh.c Geoff Wing
1997-06-19 23:32 ` SUZUKI Hisao [this message]
1997-06-20 3:45 ` zsh-3.0.3: another problem in Src/jobs.c Zoltan Hidvegi
1997-06-20 8:20 ` SUZUKI Hisao
1997-06-19 8:58 ` Peter Stephenson
1997-06-23 10:51 SUZUKI Hisao
1997-06-23 15:22 ` Zoltan Hidvegi
1997-06-24 2:05 ` SUZUKI Hisao
1997-06-24 2:52 ` Zoltan Hidvegi
1997-06-24 11:56 ` SUZUKI Hisao
[not found] <3.0.1.32.19970624091754.01331150@home.incontext.com>
1997-06-25 1:10 ` SUZUKI Hisao
1997-06-25 3:10 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9706192332.AA00517@oz.fantasy.otsl.oki.co.jp \
--to=suzuki@otsl.oki.co.jp \
--cc=hzoli@ny.frontiercomm.net \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).