From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: "Ingo Wilken" <Ingo.Wilken@Informatik.Uni-Oldenburg.DE>,
zsh-workers@math.gatech.edu, mason@primenet.com.au
Cc: ingo@malachit.Informatik.Uni-Oldenburg.DE (Ingo Wilken)
Subject: Re: Completion bug introduced in 3.0.3
Date: Tue, 1 Jul 1997 22:43:47 -0700 [thread overview]
Message-ID: <970701224347.ZM7707@candle.brasslantern.com> (raw)
In-Reply-To: <m0wjGP0-000AgCC@malachit.Informatik.Uni-Oldenburg.DE>
In-Reply-To: <slrn5rjmvs.94h.mason@coral.primenet.com.au>
On Jul 2, 5:48am, Ingo Wilken wrote:
} Subject: Completion bug introduced in 3.0.3
}
} Hi,
}
} I just upgraded from zsh 3.0.0 to 3.0.4 and noticed a severe bug with
} filename completion in multiple-line commands. I build all intermediate
} versions, and noticed that this bug was introduced with 3.0.3.
On Jul 2, 4:41am, Geoff Wing wrote:
} Subject: Re: Completion bug introduced in 3.0.3
}
} Reproduced gives:
} BUG: xorrec: ll != strlen(line)
}
} Hopefully shouldn't be too hard for someone to find (someone else, that is :-)
I've confirmed that this bug is fixed by the patch to zle_utils.c that
PWS sent some days ago, which properly nul-terminates the `line' string.
My debugging version had the patch, my regular one did not, which is why
I was not able to reproduce with debugging.
Here's the patch again, against 3.0.4 instead of 3.1.2.
Index: Src/zle_utils.c
===================================================================
--- zle_utils.c 1997/06/27 18:37:08 1.1.1.3
+++ zle_utils.c 1997/06/29 02:21:59 1.4
@@ -73,7 +73,7 @@
line[to] = line[to + cnt];
to++;
}
- ll = to;
+ line[ll = to] = '\0';
}
/**/
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next prev parent reply other threads:[~1997-07-02 6:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
1997-07-02 3:48 Ingo Wilken
1997-07-02 4:41 ` Geoff Wing
1997-07-02 5:43 ` Bart Schaefer [this message]
1997-07-02 4:51 ` Zoltan Hidvegi
1997-07-02 6:10 ` Bart Schaefer
1997-07-02 6:55 ` Zoltan Hidvegi
1997-07-04 0:53 ` Ingo Wilken
1997-07-02 5:12 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=970701224347.ZM7707@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=Ingo.Wilken@Informatik.Uni-Oldenburg.DE \
--cc=ingo@malachit.Informatik.Uni-Oldenburg.DE \
--cc=mason@primenet.com.au \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).