zsh-workers
 help / color / mirror / code / Atom feed
From: "Bart Schaefer" <schaefer@brasslantern.com>
To: Wayne Davison <wayne@clari.net>
Cc: zsh-workers@math.gatech.edu
Subject: Re: PATCH: even better history-search-{for,back}ward for 3.1.4
Date: Fri, 12 Jun 1998 21:06:13 -0700	[thread overview]
Message-ID: <980612210613.ZM24296@candle.brasslantern.com> (raw)
In-Reply-To: <199806100851.BAA05622@bebop.clari.net>

} > I hope not ... the new code ought to search for "fc" (without the
} > space),
} 
} No, the only time history-search-backward omits the space is if you
} start the search without a space on the line

That means that a line consisting of exactly one word, say "ls", does
not match a search for `a line beginning with the first word of "ls -l"'.
It also means that a line beginning with "ls	" (tab) won't match.

I see that this has actually been a bug all along, and your patch is at
least better in that you can get rid of the space by cursor positioning;
but surely if metadiffer() can't handle `word boundary' as a token, then
it should get special-cased in the caller rather than using space as a
poor substitute ...

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


  parent reply	other threads:[~1998-06-13  4:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-06-09 22:42 PATCH: revamped " Wayne Davison
1998-06-10  3:58 ` Bart Schaefer
1998-06-10  8:51   ` PATCH: even better " Wayne Davison
1998-06-10  9:23     ` Bart Schaefer
1998-06-10  9:33       ` Wayne Davison
1998-06-13  4:06     ` Bart Schaefer [this message]
1998-06-15 16:49       ` Wayne Davison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=980612210613.ZM24296@candle.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=wayne@clari.net \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).