Zsh 3.1.4 "BUG: useheap in doexpandhist()" on completion from zle widget

Zsh 3.1.4 "BUG: useheap in doexpandhist()" on completion from zle widget

[Bart Schaefer]

The setup:
__________

function frob { echo x $BUFFER x $LBUFFER x $RBUFFER x }
function prefrob { zle expand-or-complete; zle redisplay }

compctl -K frob foo
zle -N prefrob prefrob
bindkey \^I prefrob
__________

Now:

zsh% foo <TAB>

and the BUG warning appears.  The frob function is just to demonstrate that
completion is indeed being invoked from prefrob; it actually doesn't matter
what the completion is.  Any call to expand-or-complete (or related widgets)
from a user-defined widget will trigger the problem.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

PATCH: Re: Zsh 3.1.4 "BUG: useheap in doexpandhist()" on completion from zle widget

[Bart Schaefer]

On Aug 5,  4:27pm, Bart Schaefer wrote:
} Subject: Zsh 3.1.4 "BUG: useheap in doexpandhist()" on completion from zle
}
} Any call to expand-or-complete (or related widgets)
} from a user-defined widget will trigger the problem.

It took a bit of staring to figure out where to put this fix, but it looks
pretty straightforward.  Have I overlooked anything?

Index: Src/Zle/zle_thingy.c
===================================================================
RCS file: /extra/cvsroot/zsh/zsh-3.1/Src/Zle/zle_thingy.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 zle_thingy.c
--- zle_thingy.c	1998/06/01 17:08:46	1.1.1.1
+++ zle_thingy.c	1998/08/24 00:17:42
@@ -468,7 +468,9 @@
 	return 1;
     }
     t = rthingy(args[0]);
-    execzlefunc(t);
+    PERMALLOC {
+      execzlefunc(t);
+    } LASTALLOC;
     unrefthingy(t);
     return 0;
 }

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com