zsh-workers
 help / color / mirror / code / Atom feed
From: "Bart Schaefer" <schaefer@brasslantern.com>
To: zsh-workers@math.gatech.edu (Zsh hackers list)
Subject: Re: PATCH: 3.1.4: (alternative) neg-argument fix
Date: Fri, 9 Oct 1998 08:44:44 -0700	[thread overview]
Message-ID: <981009084444.ZM24902@candle.brasslantern.com> (raw)
In-Reply-To: <9810091125.AA12690@ibmth.df.unipi.it>

On Oct 9,  1:25pm, Peter Stephenson wrote:
} Subject: PATCH: 3.1.4: (alternative) neg-argument fix
}
} There was a patch from Bart back in zsh-workers/4268 to fix a problem
} with neg-argument (\e- in emacs mode), namely \e-\e1 gave you 11
} instead of 1 and so on.  Now I come to look at this, I can't get it to
} work, i.e. neg-argument won't function at all.

Hmm.  I believe you're right.  I changed the 3.1.4 code to match the
equivalent code in 3.0.5, but I missed that digitargument() zeros
zmod.tmult when MOD_TMULT isn't flagged.  (3.0.5 never zeroes zmult,
and always multiplies by it.)

} I couldn't see a way of doing this without
} adding a new flag, though that doesn't mean there isn't one.

Has the whole multiplier thing become more complicated than necessary in
3.1.4?  MOD_TMULT obviously does more than the `gotmult' global in 3.0.5
did.

In any case, Peter's patch is preferable to mine.

} Is there any enthusiasm for upgrading universal-argument to do what
} emacs does, that is to take any following digits as part of the
} argument?

YES!  That would be so much easier than having to clamp down Alt or hit
ESC repeatedly to enter the digits.  Just remember that it also needs
to take a following `-' as part of the argument.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


  reply	other threads:[~1998-10-09 15:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-10-09 11:25 Peter Stephenson
1998-10-09 15:44 ` Bart Schaefer [this message]
1998-10-10 16:33   ` PATCH: 3.1.4: universal-argument upgrade Peter Stephenson
1998-10-12  8:37     ` PATCH: 3.1.4: alternative " Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=981009084444.ZM24902@candle.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).