From: Peter Stephenson <pws@ibmth.df.unipi.it>
To: zsh-workers@math.gatech.edu (Zsh hackers list)
Subject: PATCH: Re: Two more (possible) problems with the new completion...
Date: Thu, 05 Nov 1998 13:44:27 +0100 [thread overview]
Message-ID: <9811051244.AA17981@ibmth.df.unipi.it> (raw)
In-Reply-To: "Sven Wischnowsky"'s message of "Thu, 05 Nov 1998 13:05:24 NFT." <199811051205.NAA31465@beta.informatik.hu-berlin.de>
Sven Wischnowsky wrote:
> `-W' behaves like `-k', you only need `compctl -W cdpath -/ cd'. There
> is some extra hacklet that ensures that the old style (giving one
> directory) still works (in most cases): if the string isn't an
> parameter name, it is used directly as a directory name. So, unless
> you have a directory named `$cdpath' (*not* the value of `cdpath') it
> will produce no matches.
Fine, but ... :-)
In this case the return value of get_user_var() is a pointer to the
stored array itself, so the array shouldn't be modified. The present
code does a mischief to the value of $cdpath after the completion is
finished. The patch below fixes it (I can even do this one myself).
> > so at some point the cursor is being put one character too far back.
> > It doesn't happen with a `genuine' autoremoveslash.
>
> This is a real bug (there really is an embarassing number of them,
> sigh). The cursor should be moved on the suffix only when completing
> inside words (paths, whatever).
This works fine. I don't think it's suprising that there are small
bugs left, it was a major change to the most complicated part of the
shell (possibly the most complicated part of any shell).
*** Src/Zle/zle_tricky.c.arr Thu Nov 5 13:16:46 1998
--- Src/Zle/zle_tricky.c Thu Nov 5 13:31:47 1998
***************
*** 3854,3872 ****
addwhat = CC_FILES;
if (cc->withd) {
! char **pp, *tp;
int tl = strlen(ppre) + 2, pl;
! if ((dirs = pp = get_user_var(cc->withd))) {
while (*pp) {
pl = strlen(*pp);
tp = (char *) halloc(strlen(*pp) + tl);
strcpy(tp, *pp);
tp[pl] = '/';
strcpy(tp + pl + 1, ppre);
! *pp = tp;
pp++;
}
}
}
if (!dirs) {
--- 3854,3875 ----
addwhat = CC_FILES;
if (cc->withd) {
! char **pp, **npp, *tp;
int tl = strlen(ppre) + 2, pl;
! if ((pp = get_user_var(cc->withd))) {
! dirs = npp =
! (char*) halloc(sizeof(char *)*(arrlen(pp)+1));
while (*pp) {
pl = strlen(*pp);
tp = (char *) halloc(strlen(*pp) + tl);
strcpy(tp, *pp);
tp[pl] = '/';
strcpy(tp + pl + 1, ppre);
! *npp++ = tp;
pp++;
}
+ *npp = '\0';
}
}
if (!dirs) {
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarotti 2, 56100 Pisa, Italy
next prev parent reply other threads:[~1998-11-05 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-11-05 12:05 Sven Wischnowsky
1998-11-05 12:44 ` Peter Stephenson [this message]
1998-11-05 12:56 ` PATCH: " Peter Stephenson
1998-11-05 13:21 Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9811051244.AA17981@ibmth.df.unipi.it \
--to=pws@ibmth.df.unipi.it \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).