From: "Bart Schaefer" <schaefer@brasslantern.com>
To: Geoff Wing <gcw@pobox.com>, Zsh Hackers <zsh-workers@math.gatech.edu>
Subject: Re: PATCH: 3.1.5: ``***'' symlink follow broken
Date: Thu, 12 Nov 1998 02:04:22 -0800 [thread overview]
Message-ID: <981112020422.ZM10056@candle.brasslantern.com> (raw)
In-Reply-To: <19981112172055.A21356@primenet.com.au>
On Nov 12, 5:20pm, Geoff Wing wrote:
} Subject: PATCH: 3.1.5: ``***'' symlink follow broken
}
} ``***'' recursive globbing with symlink follow has been broken since at
} least 3.1.2 (maybe before):
[...]
} This patch is probably suboptimal (possibly wrong) and may encourage someone
} to make a real patch.
[...]
} ! if (dirs && !q->follow) {
I think the semantically correct test is
if (dirs && !closure) {
but it may be that the only time it makes a difference is when all of
the subdirectories are symlinks. I keep thinking there must be some
other case that will fail if !q->follow is tested instead, but I can't
quite figure out what.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next prev parent reply other threads:[~1998-11-12 10:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-11-12 6:20 Geoff Wing
1998-11-12 10:04 ` Bart Schaefer [this message]
1998-11-12 14:10 ` Peter Stephenson
1998-11-12 14:58 ` Bruce Stephens
1998-11-12 17:21 ` Bart Schaefer
1998-11-13 8:55 ` Peter Stephenson
1998-11-13 6:59 ` Geoff Wing
1998-11-13 17:15 ` PATCH: */* broken (Re: PATCH: 3.1.5: ``***'' symlink follow broken) Bart Schaefer
1998-11-14 12:38 ` Geoff Wing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=981112020422.ZM10056@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=gcw@pobox.com \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).