From: Peter Stephenson <pws@ibmth.df.unipi.it>
To: zsh-workers@math.gatech.edu (Zsh hackers list)
Subject: PATCH: 3.1.5: unsetting special parameter
Date: Tue, 17 Nov 1998 13:55:18 +0100 [thread overview]
Message-ID: <9811171255.AA54479@ibmth.df.unipi.it> (raw)
Unrelated parameters fix: the only thing I don't understand is how it
got into 3.1.5 in the first place, which usually means it was my
fault. It didn't show up in base 3.1.5 because the `if (locallevel)'
bit wasn't there, so the shell never tried to delete any parameters;
now it deletes things it shouldn't (I found this via a warning from
mem.c). This patch is against the latest version of the associative
array story, but the effect of it is necessary (though lower priority)
anyway: just replacing the offending line by hand will work.
*** Src/params.c.unset Mon Nov 16 17:34:17 1998
--- Src/params.c Tue Nov 17 13:48:08 1998
***************
*** 1558,1564 ****
* is called. Beyond that, there is an ambiguity: should *
* foo() { local bar; unset bar; } make the global bar *
* available or not? The following makes the answer "no". */
! if (locallevel && locallevel >= pm->level)
return;
paramtab->removenode(paramtab, pm->nam); /* remove parameter node from table */
--- 1558,1564 ----
* is called. Beyond that, there is an ambiguity: should *
* foo() { local bar; unset bar; } make the global bar *
* available or not? The following makes the answer "no". */
! if ((locallevel && locallevel >= pm->level) || (pm->flags & PM_SPECIAL))
return;
paramtab->removenode(paramtab, pm->nam); /* remove parameter node from table */
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56100 Pisa, Italy
reply other threads:[~1998-11-17 13:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9811171255.AA54479@ibmth.df.unipi.it \
--to=pws@ibmth.df.unipi.it \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).