From: "Bart Schaefer" <schaefer@brasslantern.com>
To: Phil Pennock <phil@athenaeum.demon.co.uk>,
zsh-workers@math.gatech.edu (Zsh Development Workers)
Subject: Re: zle vi-mode tilde bug?
Date: Sat, 21 Nov 1998 15:59:06 -0800 [thread overview]
Message-ID: <981121155906.ZM28341@candle.brasslantern.com> (raw)
In-Reply-To: <199811212133.VAA00956@athenaeum.demon.co.uk>
On Nov 21, 9:33pm, Phil Pennock wrote:
} Subject: zle vi-mode tilde bug?
}
} Looking at Zle/zle_vi.c (vioperswapcase) there is an explicit call to
} vifirstnonblank() which explains the behaviour, but not the reasoning.
} Just before that call, cs is reset to a saved value.
}
} Am I missing something or is this a bug? It seems ... strange.
I've been playing with this and I agree that the behavior is pretty odd.
The following patch seems to make it more sensible; with this patch, the
cursor always ends up at the end of the motion, except that on ~~ (upcase
the current line) it always ends up at the end of the line.
BTW, there doesn't seem to be any sensible way to use vi-oper-swap-case
on the very last character of any line. ~l just beeps because the cursor
can't move left.
"oldcs" is perhaps no longer the best name for the variable, but ...
Index: Src/Zle/zle_vi.c
===================================================================
--- zle_vi.c 1998/11/04 17:13:58 1.2
+++ zle_vi.c 1998/11/21 23:50:28
@@ -551,12 +551,15 @@
void
vioperswapcase(void)
{
- int oldcs, c2;
+ int oldcs = cs, oldbol = findbol(), c2;
/* get the range */
startvichange(1);
if ((c2 = getvirange(0)) != -1) {
- oldcs = cs;
+ if (cs < oldbol || c2 == oldcs)
+ oldcs = cs;
+ else if (cs == oldcs || c2 >= findeol())
+ oldcs = c2;
/* swap the case of all letters within range */
while (cs < c2) {
if (islower(line[cs]))
@@ -565,9 +568,7 @@
line[cs] = tulower(line[cs]);
cs++;
}
- /* go back to the first line of the range */
cs = oldcs;
- vifirstnonblank();
}
vichgflag = 0;
}
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next prev parent reply other threads:[~1998-11-22 0:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1998-11-21 21:33 Phil Pennock
1998-11-21 23:59 ` Bart Schaefer [this message]
1998-11-22 3:31 ` Phil Pennock
1998-11-22 4:10 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=981121155906.ZM28341@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=phil@athenaeum.demon.co.uk \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).