From: Peter Stephenson <p.w.stephenson@ntlworld.com>
To: zsh-workers@zsh.org
Subject: Re: [bug] busyloop upon $=var with NULs when $IFS contains both NUL and a byte > 0x7f
Date: Tue, 13 Dec 2022 10:13:21 +0000 (GMT) [thread overview]
Message-ID: <985975587.7151691.1670926401043@mail.virginmedia.com> (raw)
In-Reply-To: <98F2CEB4-691A-4DA3-9B41-5341EA3E8B9B@kba.biglobe.ne.jp>
> On 13/12/2022 09:49 Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
> > 2022/11/29 23:38, Peter Stephenson <p.w.stephenson@ntlworld.com> wrote:
> >
> >> On 29/11/2022 14:27 Jun. T <takimoto-j@kba.biglobe.ne.jp> wrote:
> >> 3834 for (; *s; r++) {
> >> 3835 char *ie = itype_end(s, ISEP, 1);
> >> 3836 if (ie != s) {
> >> 3837 s = ie;
> >> ....
> >> 3840 }
> >> 3841 (void)findsep(&s, NULL, 0);
> >> ....
> >> 3845 }
> >>
> >> Here, the pointer s already points to a ISEP (\x83\x20 = metafied Nul),
> >> but itype_end() can't find the next ISEP (ie == s) due to the empty
> >> ifs_wide, and findsep() does not move s because *s is already ISEP,
> >> resulting in infinite-loop with the same s.
> >
> > I guess the obvious thing to do here is any time s doesn't move
> > give up splitting at that point.
>
> How can we 'give up'? Is it OK to call exit()?
By giving up, I meant we stop splitting at that point and leave the
rest of the string intact. If splitting fails, stop splitting...
pws
next prev parent reply other threads:[~2022-12-13 10:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-18 14:27 Stephane Chazelas
2022-11-29 14:27 ` Jun. T
2022-11-29 14:38 ` Peter Stephenson
2022-11-30 4:20 ` Bart Schaefer
2022-11-30 9:21 ` Peter Stephenson
2022-12-13 9:50 ` Jun T
2022-12-13 9:49 ` Jun T
2022-12-13 10:13 ` Peter Stephenson [this message]
2022-12-13 11:40 ` Jun T
2022-12-13 11:55 ` Peter Stephenson
2023-06-21 4:49 ` Jun T
2022-12-11 19:12 ` Stephane Chazelas
2022-12-13 9:51 ` Jun T
2022-11-30 14:56 ` Jun. T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=985975587.7151691.1670926401043@mail.virginmedia.com \
--to=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).