zsh-workers
 help / color / mirror / code / Atom feed
From: "Bart Schaefer" <schaefer@brasslantern.com>
To: "Andrej Borsenkow" <borsenkow.msk@sni.de>,
	"ZSH workers mailing list" <zsh-workers@math.gatech.edu>
Subject: Re: zsh-3.1.5-pws4. accept-and-menu-complete bug?
Date: Sun, 3 Jan 1999 18:14:36 -0800	[thread overview]
Message-ID: <990103181436.ZM2084@candle.brasslantern.com> (raw)
In-Reply-To: <000301be3493$63f80cb0$21c9ca95@mowp.siemens.ru>

On Dec 31, 10:58am, Andrej Borsenkow wrote:
} Subject: zsh-3.1.5-pws4. accept-and-menu-complete bug?
}
} bor@itsrm2:/tools/src%> bindkey '^[^M'
} "^[^M" accept-and-menu-complete
} bor@itsrm2:/tools/src%> rm -rf mc-4.5.1/^@mc-4.5.3/
} mc-4.5.1/  mc-4.5.3/  
} 
} Note this ^@ and not removed suffix instead of blank.

In acceptandmenucomplete() in zle_tricky.c, there's this fragment:

    cs = menuend + menuinsc;
    inststrlen(" ", 1, 1);
    menuinsc = menulen = 0;
    menupos = cs;

menuend is supposed to be "the end position of this string in the command
line" and menuinsc "is the length of any suffix that has been temporarily
added."  However, at that point menuend is large enough to *include* the
trailing slash.  In 3.0.5's acceptandmenucomplete(), menuinsc is not added 
when computing cs.

So I don't know if this is a general problem -- that menuend is just plain
wrong, and anything that refers to it will be messed up -- or if that ref
to menuinsc crept in by mistake and should be deleted (in which case the
suffix doesn't get autoremoved), or if there's a whole lot of suffix-removal
code that ought to be copied from 3.0.5, or what.

Sven?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


      reply	other threads:[~1999-01-04  2:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1998-12-31  7:58 Andrej Borsenkow
1999-01-04  2:14 ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=990103181436.ZM2084@candle.brasslantern.com \
    --to=schaefer@brasslantern.com \
    --cc=borsenkow.msk@sni.de \
    --cc=zsh-workers@math.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).