From: "Bart Schaefer" <schaefer@brasslantern.com>
To: zsh-workers@math.gatech.edu (Zsh hackers list)
Subject: PATCH: 3.0.5: Re: PATCH: 3.1.5-pws-4: compilation warnings
Date: Sun, 24 Jan 1999 09:17:53 -0800 [thread overview]
Message-ID: <990124091753.ZM6249@candle.brasslantern.com> (raw)
In-Reply-To: <9901201534.AA26168@ibmth.df.unipi.it>
On Jan 20, 4:34pm, Peter Stephenson wrote:
} Subject: PATCH: 3.1.5-pws-4: compilation warnings
}
} One of the dangling `else' branches in hist.c actually appeared to be
} a bug, with the logic not agreeing with the indentation.
That sure looks like a bug to me, and 3.0.x has apparently had it too,
since as long ago as I've kept a copy in CVS. Here's the patch for that
one bug, against 3.0.5.
Index: Src/hist.c
===================================================================
--- hist.c 1998/07/02 15:56:02 1.8
+++ hist.c 1999/01/24 17:13:23
@@ -304,7 +304,7 @@
c = ingetc();
}
*ptr = 0;
- if (!*buf)
+ if (!*buf) {
if (c != '%') {
if (isset(CSHJUNKIEHISTORY))
ev = curhist - 1;
@@ -320,6 +320,7 @@
else
ev = defev;
evset = 0;
+ }
} else if ((t0 = atoi(buf))) {
ev = (t0 < 0) ? curhist + t0 : t0;
evset = 1;
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next prev parent reply other threads:[~1999-01-24 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-01-20 15:34 Peter Stephenson
1999-01-24 17:17 ` Bart Schaefer [this message]
1999-01-24 18:02 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990124091753.ZM6249@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@math.gatech.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).