From: "Bart Schaefer" <schaefer@brasslantern.com>
To: Peter Stephenson <pws@ibmth.df.unipi.it>,
zsh-workers@sunsite.auc.dk (Zsh hackers list)
Subject: Re: PATCH: 3.1.5-pws-5++: typeset -T fixlet
Date: Sat, 30 Jan 1999 10:19:34 -0800 [thread overview]
Message-ID: <990130101934.ZM12642@candle.brasslantern.com> (raw)
In-Reply-To: <9901301316.AA64877@ibmth.df.unipi.it>
On Jan 30, 2:16pm, Peter Stephenson wrote:
} Subject: PATCH: 3.1.5-pws-5++: typeset -T fixlet
}
} --- Src/params.c.tied2 Fri Jan 29 17:36:10 1999
} +++ Src/params.c Sat Jan 30 14:02:11 1999
} @@ -1501,7 +1501,7 @@
} if (!(v = getvalue(&s, 1)))
} createparam(t, PM_SCALAR);
} else if (PM_TYPE(v->pm->flags) == PM_ARRAY &&
} - !(v->pm->flags & PM_SPECIAL) && unset(KSHARRAYS)) {
} + !(v->pm->flags & (PM_SPECIAL|PM_TIED)) && unset(KSHARRAYS)) {
} unsetparam(t);
} createparam(t, PM_SCALAR);
} v = NULL;
This hunk failed for me because Peter's copy of the source STILL doesn't
have the change from
else if (PM_TYPE(v->pm->flags) == PM_ARRAY &&
to
else if ((PM_TYPE(v->pm->flags) & (PM_ARRAY|PM_HASHED)) &&
Peter, is there some reason you keep leaving this out? I keep sending
patches for it every time you do another -pws-N release, but it never
makes it into your source code. If it'd be wrong for some reason, I'd
sure like to know why.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next prev parent reply other threads:[~1999-01-30 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-01-29 17:00 PATCH: 3.1.5-pws-5++: tidying up zle parameters Peter Stephenson
1999-01-30 13:16 ` PATCH: 3.1.5-pws-5++: typeset -T fixlet Peter Stephenson
1999-01-30 18:19 ` Bart Schaefer [this message]
1999-02-01 8:33 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990130101934.ZM12642@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=pws@ibmth.df.unipi.it \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).