From: Peter Stephenson <pws@ibmth.df.unipi.it>
To: zsh-workers@sunsite.auc.dk
Subject: Re: globcomplete bug + bug when compctl.so not loaded + init patch
Date: Thu, 25 Feb 1999 12:14:05 +0100 [thread overview]
Message-ID: <9902251114.AA42228@ibmth.df.unipi.it> (raw)
In-Reply-To: "Sven Wischnowsky"'s message of "Wed, 24 Feb 1999 16:13:24 NFT." <199902241513.QAA27875@beta.informatik.hu-berlin.de>
Sven Wischnowsky wrote:
> > Looks like things go haywire when globcomplete is set with new completion.
>
> The problem was that the second pointer into the match wasn't modified
> together with the main pointer. This caused a wrong value to be placed
> in one of those cline structs and later this led to an endless loop
> (trying to make a negative and decremented value match a positive value).
This doesn't seem to fix it for me; there's still something wrong in
addmatch() on the same test:
% setopt globcomplete
% setopt glob*e<TAB>
e is still not being set, so ee is wrong, so the second call to str_cline
after `if (ee != ss + sl || (lpsuf && *lspuf))' hangs.
Further up, the code is avoiding the whole file handling branch and
following the
test = domatch(s, patcomp, 0)
branch of the next main condition around 4344, and is not following the
if (!test && lpre && lpsuf) {
around 4359, so there's no opportunity for e to be set.
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
next prev parent reply other threads:[~1999-02-25 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-02-24 15:13 Sven Wischnowsky
1999-02-25 11:14 ` Peter Stephenson [this message]
-- strict thread matches above, loose matches on Subject: below --
1999-02-25 12:11 Sven Wischnowsky
1999-02-25 9:42 Sven Wischnowsky
1999-02-24 14:53 Sven Wischnowsky
1999-02-24 13:47 Peter Stephenson
1999-02-24 15:16 ` Andrej Borsenkow
1999-02-24 15:18 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9902251114.AA42228@ibmth.df.unipi.it \
--to=pws@ibmth.df.unipi.it \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).