From: Peter Stephenson <pws@ibmth.df.unipi.it>
To: zsh-workers@sunsite.auc.dk
Subject: Re: PATCH: matching in the new completion system
Date: Tue, 13 Apr 1999 16:39:55 +0200 [thread overview]
Message-ID: <9904131439.AA40214@ibmth.df.unipi.it> (raw)
In-Reply-To: "Sven Wischnowsky"'s message of "Tue, 13 Apr 1999 15:18:50 DFT." <199904131318.PAA04262@beta.informatik.hu-berlin.de>
Sven Wischnowsky wrote:
> Peter Stephenson wrote:
>
> > It gets worse after that. If I now go back and do /u/s/<TAB>, the whole
> > shell hangs completely and has to be killed from somewhere else. (I just
> > started off with /u/s/m<TAB>, but it all looks similar.)
>
> Ick. I can't reproduce this, but...
>
> Are you sure it hangs? Or is it just incredibly slow? For me, the lack
> of speed comes from the size of the directories `/usr/s*'. Also, there
> was a problem with building a pattern that is used to remove unmatched
> strings over which I stumbled when trying the same (`/u/s/<TAB>'). The
> problem was that I used `${(@M)tmp1:#(${(j:|:)~tmp2})}' where I should
> have used `${(@M)tmp1:#(${(j:|:)~${(@)tmp2:q}})}' to make sure special
> characters in the filenames are not taken as pattern characters.
It's something to with the |'s. It's trying to build a *huge* pattern like
that. By the looks of it, it includes every single thing in the command
table. It begins
*/(XNSquery|XNSrouted|acct|adfutil|allocp|arp|audit|auditbin|auditcat|
auditpr|auditselect|auditstream|automount|autopush|backbyinode|backbyname|
backup|bffcreate|biod|bootexpand|bootinfo|bootpd|bootrec...
These are the tail ends of the files in /u*/s*/*. The trace of _path_files
finishes up with
+ tmp1=( <all the files in /u*/s*/*, this looks reasonable> )
+ compadd -O tmp2 -F fignore - <all the commands from the last part of that>
+ [[ 423 -eq 0 ]]
+ [[ /usr/sbin/XNSquery == */* ]]
and then it stops. The part it's doing corresponds to
# Remove all files that weren't matched.
if [[ "$tmp1[1]" = */* ]]; then
tmp1=( "${(@M)tmp1:#*/(${(j:|:)~${(@)tmp2:q}})}" )
else
tmp1=( "${(@M)tmp1:#(${(j:|:)~${(@)tmp2:q}})}" )
fi
It does seem to be due to speed. In fact, it now takes 8 seconds just to
build all the files in the Src directory, irrespective of path completion,
which should be almost instantaneous. I smell a rat somewhere.
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
next prev parent reply other threads:[~1999-04-13 15:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-04-13 13:18 Sven Wischnowsky
1999-04-13 14:39 ` Peter Stephenson [this message]
1999-04-14 6:15 ` Andrej Borsenkow
-- strict thread matches above, loose matches on Subject: below --
1999-04-28 7:44 Sven Wischnowsky
1999-04-26 13:39 Sven Wischnowsky
1999-04-26 13:25 ` Peter Stephenson
1999-04-28 4:37 ` Bart Schaefer
1999-04-14 8:31 Sven Wischnowsky
1999-04-14 6:19 Sven Wischnowsky
1999-04-14 7:50 ` Peter Stephenson
1999-04-13 10:39 Sven Wischnowsky
1999-04-12 9:07 Sven Wischnowsky
1999-04-13 9:56 ` Andrej Borsenkow
1999-04-13 12:46 ` Andrej Borsenkow
1999-04-13 12:35 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9904131439.AA40214@ibmth.df.unipi.it \
--to=pws@ibmth.df.unipi.it \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).