From: "Bart Schaefer" <schaefer@brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: Singleton arrays treated as scalars
Date: Fri, 16 Apr 1999 00:18:36 -0700 [thread overview]
Message-ID: <990416001836.ZM13152@candle.brasslantern.com> (raw)
I wrote:
} On Apr 15, 2:08pm, Sven Wischnowsky wrote:
} } Subject: Re: BUG: zsh-3.1.5-pws-14: parameter expansion not working proper
} }
} } Now, we could make the multsub() save (and at the end restore) the
} } value of, say `static int mult_isarr'. It then sets it to zero and
} } calls paramsubst() (via prefork(), as usual). At the end of
} } paramsubst() we set `mult_isarr = isarr'.
}
} I actually tried this last night -- although I had paramsubst() set the
} static to 0 on the way in; multsub() just saved and restored it -- and
} it worked for some cases but not others, so I decided I was missing a
} subtlety somewhere and threw it out.
I tried this again and got much better results for two-or-more element
arrays, but singleton arrays were still getting subscripted as scalars.
Investigation led me to this fragment of paramsubst():
if (isarr > 0 && !plan9 && (!aval || !aval[0])) {
val = dupstring("");
isarr = 0;
} else if (isarr && aval && aval[0] && !aval[1]) {
val = aval[0];
isarr = 0;
}
Well, look at that. If we have a singleton array, make it into a scalar.
This doesn't have anything to do with multsub() at all!
Does anybody remember why this code is here? What part of the world is
going to come crashing down if that "else if" clause gets deleted?
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next reply other threads:[~1999-04-16 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-04-16 7:18 Bart Schaefer [this message]
1999-04-16 7:52 ` Geoff Wing
1999-04-16 7:38 Sven Wischnowsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990416001836.ZM13152@candle.brasslantern.com \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).