* PATCH: zsh-3.1.5-pws-17: history options again
@ 1999-05-08 14:42 Peter Stephenson
1999-05-08 23:56 ` Wayne Davison
0 siblings, 1 reply; 2+ messages in thread
From: Peter Stephenson @ 1999-05-08 14:42 UTC (permalink / raw)
To: Zsh hackers list
setopt with kshoptionprint was printing out
incrementalappendhistoryoff
which is obviously wrong. Here is a generic solution to the problem, but
maybe the option name is a bit too long, can we agree on another one before
it's too late? It's a shame the options weren't all standardised as having
`hist' rather than `history', but it's far too late to worry about that. How
about `incappendhistory'; I think 'inc' is a widely enough recognisable
abbreviation?
--- Src/options.c.iah Sat May 8 15:27:16 1999
+++ Src/options.c Sat May 8 16:37:10 1999
@@ -384,9 +384,9 @@
optno = -optno;
if (isset(KSHOPTIONPRINT)) {
if (defset(on))
- printf("no%-20s%s\n", on->nam, isset(optno) ? "off" : "on");
+ printf("no%-19s %s\n", on->nam, isset(optno) ? "off" : "on");
else
- printf("%-22s%s\n", on->nam, isset(optno) ? "on" : "off");
+ printf("%-21s %s\n", on->nam, isset(optno) ? "on" : "off");
} else if (set == (isset(optno) ^ defset(on))) {
if (set ^ isset(optno))
fputs("no", stdout);
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH: zsh-3.1.5-pws-17: history options again
1999-05-08 14:42 PATCH: zsh-3.1.5-pws-17: history options again Peter Stephenson
@ 1999-05-08 23:56 ` Wayne Davison
0 siblings, 0 replies; 2+ messages in thread
From: Wayne Davison @ 1999-05-08 23:56 UTC (permalink / raw)
To: Peter Stephenson; +Cc: Zsh hackers list
Peter Stephenson writes:
> It's a shame the options weren't all standardised as having `hist'
> rather than `history', but it's far too late to worry about that.
> How about `incappendhistory'?
We could change the new ones I added to all start with hist, if we
wanted to. For instance, `hist_sharing' instead of `shared_history'.
And how about `hist_append_each' for the `incremental_append_history'
option? Alternately, I still think it would be OK for us to just
lose the incremental append option and have it be the new way that
`append_history' works.
..wayne..
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~1999-05-08 23:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-05-08 14:42 PATCH: zsh-3.1.5-pws-17: history options again Peter Stephenson
1999-05-08 23:56 ` Wayne Davison
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).