PATCH: tty pgrp problem again

[Peter Stephenson <pws@ibmth.df.unipi.it>]

The last patch I sent didn't handle this case (this is the most difficult
one I've come across, not coincidentally compinstall uses it):

% cat tst
cat /dev/null | while read; do; done
read
% . ./tst
%

where the second read again can't read from the tty.

The only thing for it seems to be to trust the STAT_CURSH flag on the job,
which says the last stage of the pipeline was run in the current shell, and
hence must be in the foreground whatever the job number, which can get
jiggled about if there are different structures like the while-loop above
running in the current shell.  This should work, since that's what it's
there for.  But maybe there are pathological cases [the whole @!$!!! shell,
if you ask me sometimes].  This goes on top of the other one.

(I can't actually swear to understanding why thisjob isn't the job that's
terminating, but it's to do with the pipeline code.)

--- Src/jobs.c.job	Tue May 11 13:28:59 1999
+++ Src/jobs.c	Tue May 11 13:41:21 1999
@@ -183,13 +183,11 @@
 	 * and let it handle its own traps, but always allow the test
 	 * for the pgrp.
 	 */
-	if (job == thisjob) {
-	    if (jn->stat & STAT_CURSH)
-		inforeground = 1;
-	    else {
-		lastval = val;
-		inforeground = 2;
-	    }
+	if (jn->stat & STAT_CURSH)
+	    inforeground = 1;
+	else if (job == thisjob) {
+	    lastval = val;
+	    inforeground = 2;
 	}
     }
 
-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy