From: Peter Stephenson <pws@ibmth.df.unipi.it>
To: "ZSH workers mailing list" <zsh-workers@sunsite.auc.dk>
Subject: Re: pws-20: problems with "$@"
Date: Fri, 04 Jun 1999 13:56:02 +0200 [thread overview]
Message-ID: <9906041156.AA13727@ibmth.df.unipi.it> (raw)
In-Reply-To: ""Andrej Borsenkow""'s message of "Fri, 04 Jun 1999 15:52:01 DFT." <003201beae80$a8146b70$21c9ca95@mow.siemens.ru>
"Andrej Borsenkow" wrote:
> This worked for me under all ZSH versions:
>
> bor@itsrm2:/opt%> which cd
> cd () {
> builtin cd "$@" > /dev/null
> }
>
> But now I get:
>
> bor@itsrm2:~/src%> cd
> bor@itsrm2:~/src%> /bin/pwd
> /home/bor/src
> bor@itsrm2:~/src%> builtin cd
> bor@itsrm2:~%> /bin/pwd
> /home/bor
I don't know if this is the problem, which I can't reproduce, but I realise
my last patch for removing quotes around names of parameters should only
apply in braces, otherwise the final " in expressions like the one above
gets skipped too early.
Looking at this, I discovered that nested substitutions don't actually need
braces. For example,
% print $(echo \~)
~
% print $~$(echo \~)
/home/user2/pws
--- a nested substitution with globsubst turned on. I guess this is
unintentional, and it's confusing, so the patch stops this. Or does
somebody know better?
--- Src/subst.c.noqt Wed Jun 2 09:54:59 1999
+++ Src/subst.c Fri Jun 4 13:53:27 1999
@@ -976,7 +976,7 @@
zerr("bad substitution", NULL, 0);
return NULL;
}
- } else if (INULL(*s))
+ } else if (inbrace && INULL(*s))
s++;
else
break;
@@ -984,7 +984,7 @@
globsubst = globsubst && !qt;
idbeg = s;
- if ((subexp = (s[-1] && isstring(*s) &&
+ if ((subexp = (inbrace && s[-1] && isstring(*s) &&
(s[1] == Inbrace || s[1] == Inpar)))) {
int sav;
int quoted = *s == Qstring;
@@ -1168,8 +1168,9 @@
}
idend = s;
- while (INULL(*s))
- s++;
+ if (inbrace)
+ while (INULL(*s))
+ s++;
if ((colf = *s == ':'))
s++;
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
next prev parent reply other threads:[~1999-06-04 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-06-04 11:52 Andrej Borsenkow
1999-06-04 11:56 ` Peter Stephenson [this message]
1999-06-04 12:43 ` Andrej Borsenkow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9906041156.AA13727@ibmth.df.unipi.it \
--to=pws@ibmth.df.unipi.it \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).