zsh-workers
 help / color / mirror / code / Atom feed
From: Peter Stephenson <pws@ibmth.df.unipi.it>
To: zsh-workers@sunsite.auc.dk (Zsh hackers list)
Subject: PATCH: pws-21: parentheses in command word
Date: Tue, 08 Jun 1999 14:06:39 +0200	[thread overview]
Message-ID: <9906081206.AA21204@ibmth.df.unipi.it> (raw)

I mentioned this a while ago, but can't find that in the archive, because I
can never find things.

For some reason, parentheses are treated specially in the command word in
zsh, not just at the start (where, of course, they start a subshell).  I
just found a concrete example of where this causes problems:

% ./*(/om[1])<TAB>

should complete to the most recently modified directory.  Instead, the
command word is taken to be `./*' and the `(/om[1])' an argument.

I thought maybe it was for compatility with other shells, but it seems to
have the opposite effect.  Here's a stupid (but perfectly valid) example:

In ksh:
$ touch print
$ @(print|noprint) foo
foo
$ mv print noprint
$ @(print|noprint) foo
ksh: noprint: permission denied

With zsh running as ksh, the @ is taken to be the command.  This is bad.
(Presumably this is another reason why ksh doesn't use naked parentheses
for globbing.)

I suggest trying with this `feature' disabled, unless someone can come up
with a good reason for it.

*** Src/lex.c.icp	Mon Jan 25 14:59:49 1999
--- Src/lex.c.orig	Tue Jun  8 12:28:02 1999
***************
*** 898,906 ****
--- 898,917 ----
  		    e = hgetc();
  		    hungetc(e);
  		    lexstop = 0;
+ #if 1
+ 		    /* For command words, parentheses are only
+ 		     * special at the start.  But now we're tokenising
+ 		     * the remaining string.  So I don't see what
+ 		     * the old incmdpos test here is for.
+ 		     *   pws 1999/6/8
+ 		     */
+ 		    if (e == ')')
+ 			goto brk;
+ #else
  		    if (e == ')' ||
  			(incmdpos && !brct && peek != ENVSTRING))
  			goto brk;
+ #endif
  		}
  		pct++;
  	    }

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy


             reply	other threads:[~1999-06-08 12:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-06-08 12:06 Peter Stephenson [this message]
1999-06-08 14:51 ` Bart Schaefer
1999-06-08 14:30   ` Peter Stephenson
1999-06-09  8:11 ` Andrej Borsenkow
1999-06-09  7:50   ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9906081206.AA21204@ibmth.df.unipi.it \
    --to=pws@ibmth.df.unipi.it \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).