* PATCH: pws-21: parentheses in command word
@ 1999-06-08 12:06 Peter Stephenson
1999-06-08 14:51 ` Bart Schaefer
1999-06-09 8:11 ` Andrej Borsenkow
0 siblings, 2 replies; 5+ messages in thread
From: Peter Stephenson @ 1999-06-08 12:06 UTC (permalink / raw)
To: Zsh hackers list
I mentioned this a while ago, but can't find that in the archive, because I
can never find things.
For some reason, parentheses are treated specially in the command word in
zsh, not just at the start (where, of course, they start a subshell). I
just found a concrete example of where this causes problems:
% ./*(/om[1])<TAB>
should complete to the most recently modified directory. Instead, the
command word is taken to be `./*' and the `(/om[1])' an argument.
I thought maybe it was for compatility with other shells, but it seems to
have the opposite effect. Here's a stupid (but perfectly valid) example:
In ksh:
$ touch print
$ @(print|noprint) foo
foo
$ mv print noprint
$ @(print|noprint) foo
ksh: noprint: permission denied
With zsh running as ksh, the @ is taken to be the command. This is bad.
(Presumably this is another reason why ksh doesn't use naked parentheses
for globbing.)
I suggest trying with this `feature' disabled, unless someone can come up
with a good reason for it.
*** Src/lex.c.icp Mon Jan 25 14:59:49 1999
--- Src/lex.c.orig Tue Jun 8 12:28:02 1999
***************
*** 898,906 ****
--- 898,917 ----
e = hgetc();
hungetc(e);
lexstop = 0;
+ #if 1
+ /* For command words, parentheses are only
+ * special at the start. But now we're tokenising
+ * the remaining string. So I don't see what
+ * the old incmdpos test here is for.
+ * pws 1999/6/8
+ */
+ if (e == ')')
+ goto brk;
+ #else
if (e == ')' ||
(incmdpos && !brct && peek != ENVSTRING))
goto brk;
+ #endif
}
pct++;
}
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH: pws-21: parentheses in command word
1999-06-08 14:51 ` Bart Schaefer
@ 1999-06-08 14:30 ` Peter Stephenson
0 siblings, 0 replies; 5+ messages in thread
From: Peter Stephenson @ 1999-06-08 14:30 UTC (permalink / raw)
To: Zsh hackers list
"Bart Schaefer" wrote:
> } For some reason, parentheses are treated specially in the command word in
> } zsh, not just at the start (where, of course, they start a subshell).
>
> They're treated that way because array assignments are in command position.
That's a special case: if it finds an '=' in the command word, it searches
for a '(' straight afterwards, so the code for searching for a '(' on its
own isn't used. But maybe it was once.
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH: pws-21: parentheses in command word
1999-06-08 12:06 PATCH: pws-21: parentheses in command word Peter Stephenson
@ 1999-06-08 14:51 ` Bart Schaefer
1999-06-08 14:30 ` Peter Stephenson
1999-06-09 8:11 ` Andrej Borsenkow
1 sibling, 1 reply; 5+ messages in thread
From: Bart Schaefer @ 1999-06-08 14:51 UTC (permalink / raw)
To: Zsh hackers list
On Jun 8, 2:06pm, Peter Stephenson wrote:
} Subject: PATCH: pws-21: parentheses in command word
}
} I mentioned this a while ago, but can't find that in the archive, because I
} can never find things.
I frequently do searches that I *know* should succeed, but that find
nothing. I suppose I should send a couple of them off to Geoff and
ask why.
} For some reason, parentheses are treated specially in the command word in
} zsh, not just at the start (where, of course, they start a subshell).
I think know why, but perhaps now the lexer is more sophisticated. I have
an early-morning meeting today, so I don't have time to build pws-21 and
try the patch.
They're treated that way because array assignments are in command position.
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: PATCH: pws-21: parentheses in command word
1999-06-09 8:11 ` Andrej Borsenkow
@ 1999-06-09 7:50 ` Peter Stephenson
0 siblings, 0 replies; 5+ messages in thread
From: Peter Stephenson @ 1999-06-09 7:50 UTC (permalink / raw)
To: Zsh hackers list
"Andrej Borsenkow" wrote:
> |
> |*** Src/lex.c.icp Mon Jan 25 14:59:49 1999
> |--- Src/lex.c.orig Tue Jun 8 12:28:02 1999
> --------------------------
> File to patch:
>
> Is it my patch so dumb?
Sorry, I originally made the patch after applying something sent by Sven,
so it doesn't apply to Src/lex.c as it should.
*** Src/lex.c Mon Jan 25 14:59:49 1999
--- Src/lex.c.orig Tue Jun 8 12:28:02 1999
***************
*** 898,906 ****
--- 898,917 ----
e = hgetc();
hungetc(e);
lexstop = 0;
+ #if 1
+ /* For command words, parentheses are only
+ * special at the start. But now we're tokenising
+ * the remaining string. So I don't see what
+ * the old incmdpos test here is for.
+ * pws 1999/6/8
+ */
+ if (e == ')')
+ goto brk;
+ #else
if (e == ')' ||
(incmdpos && !brct && peek != ENVSTRING))
goto brk;
+ #endif
}
pct++;
}
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: PATCH: pws-21: parentheses in command word
1999-06-08 12:06 PATCH: pws-21: parentheses in command word Peter Stephenson
1999-06-08 14:51 ` Bart Schaefer
@ 1999-06-09 8:11 ` Andrej Borsenkow
1999-06-09 7:50 ` Peter Stephenson
1 sibling, 1 reply; 5+ messages in thread
From: Andrej Borsenkow @ 1999-06-09 8:11 UTC (permalink / raw)
To: Peter Stephenson, Zsh hackers list
|
|*** Src/lex.c.icp Mon Jan 25 14:59:49 1999
|--- Src/lex.c.orig Tue Jun 8 12:28:02 1999
--------------------------
File to patch:
Is it my patch so dumb?
/andrej
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~1999-06-09 8:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
1999-06-08 12:06 PATCH: pws-21: parentheses in command word Peter Stephenson
1999-06-08 14:51 ` Bart Schaefer
1999-06-08 14:30 ` Peter Stephenson
1999-06-09 8:11 ` Andrej Borsenkow
1999-06-09 7:50 ` Peter Stephenson
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).