Completion for limits

Completion for limits

[Kiddle, Oliver]

The new-style completion for limits doesn't work anymore. Patch follows:

Oliver Kiddle

*** Completion/Builtins/_limits.old     Mon Jun 14 22:45:07 1999
--- Completion/Builtins/_limits	Mon Jun 14 22:47:41 1999
***************
*** 1,3 ****
  #compdef limit unlimit
  
! compgen -k "(${(j: :)${(f)$(limit)}%% *})"
--- 1,3 ----
  #compdef limit unlimit
  
! compgen -s '${${(f)"$(limit)"}%% *}'

Re: Completion for limits

[Bart Schaefer]

On Jun 15,  9:41am, Kiddle, Oliver wrote:
} Subject: Completion for limits
}
} The new-style completion for limits doesn't work anymore.
} 
} ! compgen -k "(${(j: :)${(f)$(limit)}%% *})"
} --- 1,3 ----
} ! compgen -s '${${(f)"$(limit)"}%% *}'

Hrm.  This must have been broken for a while ... even before the change
to handling of quotes within ${...}, that would have needed to be

  compgen -k "(${(@j: :)${(f)$(limit)}%% *})"

Using `compgen -s ...' is going to re-evaluate $(limit) every time the
completion is performed.  Is adding the @ a better choice?

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Re: Completion for limits

[Peter Stephenson]

"Bart Schaefer" wrote:
> Hrm.  This must have been broken for a while ... even before the change
> to handling of quotes within ${...}, that would have needed to be
> 
>   compgen -k "(${(@j: :)${(f)$(limit)}%% *})"
> 
> Using `compgen -s ...' is going to re-evaluate $(limit) every time the
> completion is performed.  Is adding the @ a better choice?

It doesn't help you with new completion.  The same function is going to be
called every time, so the $(limit) will always be expanded anew, but before
compgen is called rather than in the bowels.  The only way round that is to
cache the value in a variable the first time and use that, which doesn't
seem worth the effort and the space.

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy