From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: 3.0.6-pre-4: Sneaky history bug
Date: Wed, 16 Jun 1999 06:47:58 +0000 [thread overview]
Message-ID: <990616064758.ZM25956@candle.brasslantern.com> (raw)
Start with an empty history, as with "zsh -f" or a non-login shell, and
then try to do a "quick substitution" on the nonexistent previous command
using the second character in $histchars (usually '^'). I found myself
in hend() with chwordpos == -2, which did all sorts of fun things when
memcpy was called with chwordpos * sizeof(short) as its third parameter.
I think only Wayne really knows what's going on in the code below, but
this patch at least seems to prevent zsh committing hara-kiri. You end
up with an empty entry in the history, though.
Index: Src/hist.c
===================================================================
@@ -719,7 +719,7 @@
}
#endif
/* get rid of pesky \n which we've already nulled out */
- if (!chline[chwords[chwordpos-2]])
+ if (chwordpos > 1 && !chline[chwords[chwordpos-2]])
chwordpos -= 2;
/* strip superfluous blanks, if desired */
if (isset(HISTREDUCEBLANKS))
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
reply other threads:[~1999-06-16 6:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990616064758.ZM25956@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).