From: Peter Stephenson <pws@ibmth.df.unipi.it>
To: zsh-workers@sunsite.auc.dk (Zsh hackers list)
Subject: PATCH: minor stuff
Date: Thu, 24 Jun 1999 18:11:41 +0200 [thread overview]
Message-ID: <9906241611.AA12953@ibmth.df.unipi.it> (raw)
I noticed that dyncat() was advertised as always using heap memory, whereas
actually it uses ncalloc() which chooses the current sort of allocation.
Since all the uses seem to be in places where the memory doesn't get
explicitly freed, maybe we should change the code to match the comment
(which I probably put there).
While I was doing this I noticed that the hashtable element tablename was
never freed. It's only used with --zsh-hash-debug.
--- Src/glob.c.dc Mon Jun 14 09:22:10 1999
+++ Src/glob.c Thu Jun 24 18:04:31 1999
@@ -1993,7 +1993,7 @@
char *ptr;
int l1 = strlen(s1);
- ptr = (char *)ncalloc(l1 + strlen(s2) + 1);
+ ptr = (char *)zhalloc(l1 + strlen(s2) + 1);
strcpy(ptr, s1);
strcpy(ptr + l1, s2);
return ptr;
--- Src/hashtable.c.dc Fri Jun 18 13:49:29 1999
+++ Src/hashtable.c Thu Jun 24 17:57:56 1999
@@ -133,6 +133,7 @@
ht->last->next = ht->next;
else
firstht = ht->next;
+ zsfree(ht->tablename);
#endif /* ZSH_HASH_DEBUG */
zfree(ht->nodes, ht->hsize * sizeof(HashNode));
zfree(ht, sizeof(*ht));
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
reply other threads:[~1999-06-24 16:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9906241611.AA12953@ibmth.df.unipi.it \
--to=pws@ibmth.df.unipi.it \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).