From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: PATCH: pws-24: Stop the unbearable beeping of magic-space
Date: Sun, 27 Jun 1999 08:42:21 +0000 [thread overview]
Message-ID: <990627084221.ZM9491@candle.brasslantern.com> (raw)
I should have noticed this when 6814 was posted, but I was preoccupied with
testing job control in 3.0.6 ...
If you have
bindkey " " magic-space
then every time you press the spacebar you get a beep, unless there happens
to be an expandable history item in the word.
Now, the really good thing would be for doexpandhist() to return failure
only if there is a history reference but it can't be expanded, rather than
failing whenever no expansion took place. It's beyond my comprehension of
the interaction between zle and the history mechanism to pull that off, so
I settled for making magic-space fail only if selfinsert() does [the old
code didn't make sense anyway -- why store the return from selfinsert and
then do nothing with it?].
Line numbers below may be off a bit, because I also got annoyed by Oliver
Kiddle's patch from 6772. Gosh, I actually went one whole revision of zsh
without having to either put in or maintain a local change ...
Index: Src/Zle/zle_tricky.c
@@ -8249,8 +8243,9 @@
{
int ret;
c = ' ';
- ret = selfinsert(args);
- return !doexpandhist();
+ if (!(ret = selfinsert(args)))
+ doexpandhist();
+ return ret;
}
/**/
--
Bart Schaefer Brass Lantern Enterprises
http://www.well.com/user/barts http://www.brasslantern.com
next reply other threads:[~1999-06-27 8:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
1999-06-27 8:42 Bart Schaefer [this message]
1999-06-27 13:25 ` Peter Stephenson
1999-06-27 16:32 ` Bart Schaefer
1999-06-28 9:03 ` job completion (was Re: PATCH: pws-24: Stop the unbearable beeping of magic-space) Oliver Kiddle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=990627084221.ZM9491@candle.brasslantern.com \
--to=schaefer@candle.brasslantern.com \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).