From: Peter Stephenson <pws@ibmth.df.unipi.it>
To: zsh-workers@sunsite.auc.dk (Zsh hackers list)
Subject: PATCH: 3.1.6-test-1: Don't use strcoll() with ranges
Date: Sun, 18 Jul 1999 17:42:20 +0200 [thread overview]
Message-ID: <9907181542.AA28118@ibmth.df.unipi.it> (raw)
Bart's pointed out to me that there was some discussion about problems with
using strcoll() inside character ranges: for one thing, [A-Z] in the de
locale matches all characters, which is not good. So this just uses ASCII
collation in this one case. You can also use [[:upper:]], of course; that
seems to be safer without this patch.
--- Src/glob.c.strcoll Thu Jun 24 18:04:31 1999
+++ Src/glob.c Sun Jul 18 17:37:35 1999
@@ -2926,7 +2926,10 @@
* and optional ^ have already been skipped. */
char *pat = *patptr;
-#ifdef HAVE_STRCOLL
+ /* We don't use strcoll() for ranges, since it can have side
+ * effects. It's less necessary now we have [:posix:] ranges.
+ */
+#if 0
char l_buf[2], r_buf[2], ch_buf[2];
ch_buf[0] = ch;
@@ -2944,7 +2947,7 @@
break;
} else if (*pat == '-' && pat[-1] != rchar &&
pat[1] != Outbrack) {
-#ifdef HAVE_STRCOLL
+#if 0
l_buf[0] = PPAT(-1);
r_buf[0] = PAT(1);
if (strcoll(l_buf, ch_buf) <= 0 &&
--
Peter Stephenson <pws@ibmth.df.unipi.it> Tel: +39 050 844536
WWW: http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy
reply other threads:[~1999-07-18 16:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9907181542.AA28118@ibmth.df.unipi.it \
--to=pws@ibmth.df.unipi.it \
--cc=zsh-workers@sunsite.auc.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).