From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 751 invoked from network); 19 Jul 1999 18:41:01 -0000 Received: from ns2.primenet.com.au (HELO primenet.com.au) (@203.24.36.3) by ns1.primenet.com.au with SMTP; 19 Jul 1999 18:41:01 -0000 Received: (qmail 29278 invoked from network); 19 Jul 1999 17:55:03 -0000 Received: from sunsite.auc.dk (130.225.51.30) by ns2.primenet.com.au with SMTP; 19 Jul 1999 17:55:03 -0000 Received: (qmail 26052 invoked by alias); 19 Jul 1999 16:22:41 -0000 Mailing-List: contact zsh-workers-help@sunsite.auc.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 7204 Received: (qmail 26045 invoked from network); 19 Jul 1999 16:22:40 -0000 Message-Id: <9907191551.AA15323@ibmth.df.unipi.it> To: zsh-workers@sunsite.auc.dk (Zsh hackers list) Subject: Re: PATCH: Re: history curiosities In-Reply-To: "Peter Stephenson"'s message of "Sun, 18 Jul 1999 16:59:28 DFT." <9907181459.AA12423@ibmth.df.unipi.it> Date: Mon, 19 Jul 1999 17:51:43 +0200 From: Peter Stephenson Peter Stephenson wrote: > The second is presumably new, and is a bit harder; I only discovered it > because of the first one. In remhist(), the hist_ring is freed under the > circumstances I'm talking about (a history command with HISTNOSTORE), but > is not set to NULL, so is referred to again with the next hbegin(). Looks like a false alarm, on closer examination. freehistnode() does indeed free the hist_ring that was around before, but freehistdata() has already unlinked it from the ring and set hist_ring to something else as a side effect. So there's nothing wrong. -- Peter Stephenson Tel: +39 050 844536 WWW: http://www.ifh.de/~pws/ Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy