From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17231 invoked from network); 31 Jul 1999 04:45:18 -0000 Received: from sunsite.auc.dk (130.225.51.30) by ns1.primenet.com.au with SMTP; 31 Jul 1999 04:45:18 -0000 Received: (qmail 529 invoked by alias); 31 Jul 1999 04:44:07 -0000 Mailing-List: contact zsh-workers-help@sunsite.auc.dk; run by ezmlm Precedence: bulk X-No-Archive: yes X-Seq: 7325 Received: (qmail 446 invoked from network); 31 Jul 1999 04:44:06 -0000 From: "Bart Schaefer" Message-Id: <990731044125.ZM1287@candle.brasslantern.com> Date: Sat, 31 Jul 1999 04:41:25 +0000 In-Reply-To: Comments: In reply to Tanaka Akira "Re: unsetopt banghist does not work." (Jul 30, 7:44pm) References: <9907300846.AA31025@ibmth.df.unipi.it> X-Mailer: Z-Mail (5.0.0 30July97) To: Tanaka Akira , zsh-workers@sunsite.auc.dk Subject: Re: unsetopt banghist does not work. MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii On Jul 30, 7:44pm, Tanaka Akira wrote: } Subject: Re: unsetopt banghist does not work. } } In article <9907300846.AA31025@ibmth.df.unipi.it>, } Peter Stephenson writes: } > I suppose I'm going to be told the following is just how history is } > supposed to work? } > } > % unsetopt banghist } > % echo !! } > !! } > % setopt banghist } > % !! } > zsh: no such word in event } } This behaviour is different to zsh-3.1.5-pws-21 and zsh-3.1.5. The problem is with this change: Sven: 6542, 6551: Don't buffer in the history code any text that won't be added to the history. This was done to speed up sourcing of files and execution of functions, but it has the side-effect of causing the history to be discarded completely when NOBANGHIST is in effect; or at least it has that effect when combined with PWS's patch of 7324. Obviously this is unacceptable -- it means that "unsetopt banghist" also disables the zle history operations. I think the following is the right fix. It goes on top of 7324. There probably ought to be some #define constants for this instead of numbers. Index: Src/hist.c =================================================================== @@ -722,7 +722,7 @@ hwend = ihwend; addtoline = iaddtoline; if (!isset(BANGHIST)) - stophist = 2; + stophist = 4; } chwordpos = 0; -- Bart Schaefer Brass Lantern Enterprises http://www.well.com/user/barts http://www.brasslantern.com