Couldn't Build 3.1.6 on Nextstep 3.3 m68k System

Couldn't Build 3.1.6 on Nextstep 3.3 m68k System

[Irving Wolfe]

The make ended thus:

Updated `zshpaths.h'.
Creating `zshxmods.h'.
cc -c -I.  -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -O2  -o init.o init.c
init.c: In function `init_io':
init.c:360: too few arguments to function `fcntl'
init.c:364: too few arguments to function `fcntl'
*** Exit 1
Stop.

I will be happy to provide additional
useful information on request, if you tell
me what would help and how to get it.  I am
only a beginner. 

Re: Couldn't Build 3.1.6 on Nextstep 3.3 m68k System

[Timothy J Luoma]

Replying to message of Sun, 1 Aug 1999 21:45:23 -0700 (PDT)
	from Irving Wolfe <irving@Happy-Man.com>
	regarding ``Couldn't Build 3.1.6 on Nextstep 3.3 m68k System''
	
> The make ended thus:
>
> Updated `zshpaths.h'.
> Creating `zshxmods.h'.
> cc -c -I. -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -O2 -o
> init.o init.c init.c: In function `init_io':
> init.c:360: too few arguments to function `fcntl'
> init.c:364: too few arguments to function `fcntl'
> *** Exit 1
> Stop.
>
> I will be happy to provide additional
> useful information on request, if you tell
> me what would help and how to get it.  I am
> only a beginner.

I __think__ you can solve this by adding the -posix glad to CC

Are you using gnumake rather than regular make?  I find it to be generally better.

I should try 3.1.6 too, haven't had time.

TjL, with a 3.3/4.2 NeXT setup & zsh

Re: Couldn't Build 3.1.6 on Nextstep 3.3 m68k System

[Irving_Wolfe]

I tried -posix as suggested and got:

cc -c -I.  -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -O2 -posix -o init.o init.c
system.h:74: warning: could not use precompiled header
'/NextDeveloper/Headers/bsd/libc.p', because:
system.h:74: warning: #ifdef '_POSIX_SOURCE' not defined when precompiled, but now defined:
system.h:74: warning:   on the command line
In file included from /NextDeveloper/Headers/bsd/libc.h:16, from system.h:74, from zsh.mdh:6, from init.c:30:
/NextDeveloper/Headers/bsd/sys/types.h:136: warning: useless keyword or type name in empty declaration
/NextDeveloper/Headers/bsd/sys/types.h:137: warning: useless keyword or type name in empty declaration
In file included from /NextDeveloper/Headers/bsd/sys/param.h:103, from /NextDeveloper/Headers/bsd/libc.h:21, from system.h:74, from zsh.mdh:6, from init.c:30:
/NextDeveloper/Headers/bsd/sys/signal.h:239: warning: useless keyword or type name in empty declaration
init.c: In function `init_io':
init.c:393: too many arguments to function `getpgrp'
init.c:394: too many arguments to function `getpgrp'
init.c:397: too many arguments to function `getpgrp'
init.c:401: too many arguments to function `getpgrp'
*** Exit 1
Stop.


On Mon, Aug 02, 1999 at 12:51:25AM -0400, Timothy J Luoma wrote:
> Replying to message of Sun, 1 Aug 1999 21:45:23 -0700 (PDT)
> 	from Irving Wolfe <irving@Happy-Man.com>
> 	regarding ``Couldn't Build 3.1.6 on Nextstep 3.3 m68k System''
> 	
> > The make ended thus:
> >
> > Updated `zshpaths.h'.
> > Creating `zshxmods.h'.
> > cc -c -I. -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -O2 -o
> > init.o init.c init.c: In function `init_io':
> > init.c:360: too few arguments to function `fcntl'
> > init.c:364: too few arguments to function `fcntl'
> > *** Exit 1
> > Stop.
> 
> I __think__ you can solve this by adding the -posix glad to CC

Regards,
 - Irving

Re: Couldn't Build 3.1.6 on Nextstep 3.3 m68k System

[Geoff Wing]

Irving Wolfe <irving@Happy-Man.com> typed:
:The make ended thus:
:
:Updated `zshpaths.h'.
:Creating `zshxmods.h'.
:cc -c -I.  -DHAVE_CONFIG_H -Wall -Wno-implicit -Wmissing-prototypes -O2  -o init.o init.c
:init.c: In function `init_io':
:init.c:360: too few arguments to function `fcntl'
:init.c:364: too few arguments to function `fcntl'
:*** Exit 1
:Stop.

Try the following; with F_GETFL, all args are ignored anyway.


--- Src/init.c.org	Wed Jun 30 02:33:52 1999
+++ Src/init.c	Mon Aug  2 16:05:27 1999
@@ -353,7 +353,7 @@
 	 * Try both stdin and stdout before trying /dev/tty. -- Bart
 	 */
 #if defined(HAVE_FCNTL_H) && defined(F_GETFL)
-#define rdwrtty(fd)	((fcntl(fd, F_GETFL) & O_RDWR) == O_RDWR)
+#define rdwrtty(fd)	((fcntl(fd, F_GETFL, 0) & O_RDWR) == O_RDWR)
 #else
 #define rdwrtty(fd)	1
 #endif


-- 
Geoff Wing : <gcw@pobox.com>     Work URL: http://www.primenet.com.au/
Rxvt Stuff : <gcw@rxvt.org>      Ego URL : http://pobox.com/~gcw/
Zsh Stuff  : <gcw@zsh.org>       Phone   : (Australia) 0413 431 874

Re: Couldn't Build 3.1.6 on Nextstep 3.3 m68k System

[Irving_Wolfe]

Thanks for the great help!

On Mon, Aug 02, 1999 at 06:06:29AM +0000, Geoff Wing wrote:
> 
> Try the following; with F_GETFL, all args are ignored anyway.
> 
> 
> --- Src/init.c.org	Wed Jun 30 02:33:52 1999
> +++ Src/init.c	Mon Aug  2 16:05:27 1999
> @@ -353,7 +353,7 @@
>  	 * Try both stdin and stdout before trying /dev/tty. -- Bart
>  	 */
>  #if defined(HAVE_FCNTL_H) && defined(F_GETFL)
> -#define rdwrtty(fd)	((fcntl(fd, F_GETFL) & O_RDWR) == O_RDWR)
> +#define rdwrtty(fd)	((fcntl(fd, F_GETFL, 0) & O_RDWR) == O_RDWR)
>  #else
>  #define rdwrtty(fd)	1
>  #endif

That worked for init.c, but I had to make
a similar change in utils.c:

--- /Maurice/irving/todelete/01utils.c  Sun Aug  1 23:27:41 1999
+++ Src/utils.c Sun Aug  1 23:28:36 1999
@@ -1249,7 +1249,7 @@
     long mode;

     if (!fstat(0, &st) && !S_ISREG(st.st_mode)) {
-       mode = fcntl(0, F_GETFL);
+       mode = fcntl(0, F_GETFL, 0);
        if (mode != -1 && (mode & NONBLOCK) &&
            !fcntl(0, F_SETFL, mode & ~NONBLOCK))
            return 1;

Then, zsh was built (and seems to run okay)
but my "make" still failed:

 cc  -s  -o zsh main.o `cat stamp-modobjs`   -ltermcap
makeinfo ./zsh.texi; exit 0
Making info file `zsh.info' from `./zsh.texi'.
./zsh.texi:19: Unknown info command `dircategory'.
./zsh.texi:20: Unknown info command `direntry'.
./zsh.texi:23: Bad argument to `end', `direntry', using `ifinfo'.
./zsh.texi:23: Unmatched `@end'.
*** Exit 2
*** `zsh.info' removed
Stop.
*** Exit 1

If there is anything after that info step,
I wonder if it should fail more gracefully,
since even FSF's efforts haven't gotten me
to read info files very often.

Regards,
 - Irving

Re: Couldn't Build 3.1.6 on Nextstep 3.3 m68k System

[Peter Stephenson]

Irving_Wolfe@Happy-Man.com wrote:
> makeinfo ./zsh.texi; exit 0
> Making info file `zsh.info' from `./zsh.texi'.
> ./zsh.texi:19: Unknown info command `dircategory'.
> ./zsh.texi:20: Unknown info command `direntry'.
> ./zsh.texi:23: Bad argument to `end', `direntry', using `ifinfo'.
> ./zsh.texi:23: Unmatched `@end'.
> *** Exit 2
> *** `zsh.info' removed
> Stop.
> *** Exit 1
> 
> If there is anything after that info step,
> I wonder if it should fail more gracefully,
> since even FSF's efforts haven't gotten me
> to read info files very often.

...and the info files aren't installed by default, either.  But that's
presumably the reason why the `exit 0' was added.  Why is it being
interpreted as `exit 2'?  Is make working too hard and intercepting the
intermediate exit status?  Should that be `makeinfo ./zsh.texi || exit 0'?

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

Re: Couldn't Build 3.1.6 on Nextstep 3.3 m68k System

[Bart Schaefer]

On Aug 2,  9:51am, Peter Stephenson wrote:
} Subject: Re: Couldn't Build 3.1.6 on Nextstep 3.3 m68k System
}
} Irving_Wolfe@Happy-Man.com wrote:
} > makeinfo ./zsh.texi; exit 0
} > *** Exit 2
} 
} Why is it being interpreted as `exit 2'?

"make" runs "$SHELL -e ..." so any command in a semicolon-separated list
will abort the shell if it returns a nonzero status.

} Should that be `makeinfo ./zsh.texi || exit 0'?

Yes.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com

Re: Couldn't Build 3.1.6 on Nextstep 3.3 m68k System

[Peter Stephenson]

"Bart Schaefer" wrote:
> Yes.

--- Doc/Makefile.in.bak	Mon Aug  2 09:37:18 1999
+++ Doc/Makefile.in	Mon Aug  2 11:00:21 1999
@@ -74,7 +74,7 @@
 	$(TEXI2DVI) $(sdir)/zsh.texi
 
 zsh.info: zsh.texi
-	$(MAKEINFO) $(sdir)/zsh.texi; exit 0
+	$(MAKEINFO) $(sdir)/zsh.texi || exit 0
 
 zsh.texi: zsh.yo
 	$(YODL) -o $(sdir)/zsh.texi -I$(sdir) -w ztexi.yo version.yo zsh.yo

-- 
Peter Stephenson <pws@ibmth.df.unipi.it>       Tel: +39 050 844536
WWW:  http://www.ifh.de/~pws/
Dipartimento di Fisica, Via Buonarroti 2, 56127 Pisa, Italy

RE: Couldn't Build 3.1.6 on Nextstep 3.3 m68k System

[Andrej Borsenkow]

>
>  cc  -s  -o zsh main.o `cat stamp-modobjs`   -ltermcap
> makeinfo ./zsh.texi; exit 0
> Making info file `zsh.info' from `./zsh.texi'.
> ./zsh.texi:19: Unknown info command `dircategory'.
> ./zsh.texi:20: Unknown info command `direntry'.
> ./zsh.texi:23: Bad argument to `end', `direntry', using `ifinfo'.
> ./zsh.texi:23: Unmatched `@end'.


This means, you have old version of texinfo. Is it possible to check texinfo
version at runtime in texi file?

/andrej