zsh-workers
 help / color / mirror / code / Atom feed
From: "Bart Schaefer" <schaefer@candle.brasslantern.com>
To: zsh-workers@sunsite.auc.dk
Subject: Re: exec last command in last pipeline.
Date: Sat, 14 Aug 1999 22:05:30 +0000	[thread overview]
Message-ID: <990814220530.ZM6932@candle.brasslantern.com> (raw)
In-Reply-To: <rsq7lmy73h0.fsf@crane.jaist.ac.jp>

On Aug 15,  1:04am, Tanaka Akira wrote:
} Subject: exec last command in last pipeline.
}
} --- exec.c	1999/07/24 14:02:56	1.1.1.19
} +++ exec.c	1999/08/14 15:55:32
} @@ -1522,7 +1522,7 @@
}  
}  	    /* Current shell should not fork unless the *
}  	     * exec occurs at the end of a pipeline.    */
} -	    if ((cflags & BINF_EXEC) && last1 == 2)
} +	    if ((cflags & BINF_EXEC) && last1)
}  		flags |= CFLAG_EXEC;
}  
}  	    /* Empty command */

I'm extremely dubious of that change.  The only way that last1 can be set
to 2 is here in execpline2():

    if (pline->type == END)
    	execcmd(pline->left, input, output, how, last1 ? 1 : 2);

If you remove the test of last1 == 2 in execcmd(), there's no reason to
test for last1 in execpline2().  But both tests have been there since
before version 3.0.0; I'm concerned that the shell is going to exec in
some cases where it should not.

-- 
Bart Schaefer                                 Brass Lantern Enterprises
http://www.well.com/user/barts              http://www.brasslantern.com


  reply	other threads:[~1999-08-14 22:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-08-14 16:04 Tanaka Akira
1999-08-14 22:05 ` Bart Schaefer [this message]
1999-08-15  6:12   ` Tanaka Akira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=990814220530.ZM6932@candle.brasslantern.com \
    --to=schaefer@candle.brasslantern.com \
    --cc=zsh-workers@sunsite.auc.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).